Precompute power if both arguments are constants - #1529
Closed
MaxGraey wants to merge 8 commits into
Closed
Conversation
Member
|
What do you think of making this a new pass in PostAssemblyScript.cpp on the Binaryen end? Would imagine that we can do much more there, in this case for example postprocessing calls to |
Member
Author
|
Yeah, it could be binaryen's pass. But this PR useful in any case even with our custom Binaryen pass due to it works for untouched version as well. Ofc for simple cases |
Member
Author
|
Btw we could extend values like |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dcodeIO I know we already talked about this and I understand this not general solution but until we haven't own IR I propose do this due to expessions like
10 ** 5,2 ** 23and etc is pretty popular as I see.