Fix time-domain convolution kernel orientation - #3083
Open
Con-Benksl wants to merge 1 commit into
Open
Con-Benksl wants to merge 1 commit into
Con-Benksl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1527.
convolve1d(..., use_fft=False)currently performs cross-correlation because it passes the kernel directly to PyTorch'sconv1d. For a waveform[1, 2, 3, 4]and kernel[1, 2, 4], it returns[17, 24]instead of the valid convolution[11, 18]. Reverse the kernel along its time axis before calling PyTorch.This intentionally changes time-domain results for asymmetric kernels.
DropFrequses this path both to build and apply its filter; its existing frequency-rejection tests pass, and old/new waveform comparisons agree within floating-point tolerance (bitwise reproducibility is not promised). The FFT path, including the defaultreverberateimplementation, is unchanged.Validation on CPU with PyTorch 2.6.0:
pre-commit run -aandgit diff --checkpass. No model or dataset downloads were needed. The full repository test suite and GPU execution were not run.Implemented and tested autonomously with OpenAI Codex, with a separate agent reviewing the code, callers, and compatibility checks.
Before submitting
PR review
Reviewer checklist