Skip to content

The rir_waveform should be flipped in reverberate, when use_fft=False? #1527

Description

@nateanl

When applying convolution on waveforms and rir_waveform, the rir_waveform is flipped in numpy or scipy implementations. But in speechbrain's implementation, the rir_waveform is directly used when the solution is not FFT. This may lead to mismatch between the two solutions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions