Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions master/custom/factories.py
Original file line number Diff line number Diff line change
Expand Up @@ -1320,15 +1320,19 @@ class AndroidBuild(BaseBuild):
"""Build Python for Android on a Linux or Mac machine, and test it using a
Gradle-managed emulator.

To set up a worker, see cpython/Android/README.md, especially the following
sections:
To set up a worker, see cpython/Platforms/Android/README.md, especially the
following sections:

* Install everything listed under "Prerequisites".
* Do any OS-specific setup mentioned under "Testing".
* If the managed emulator appears to be running out of memory, increase
its RAM size as described under "Testing".
"""

# When Gradle is interrupted, e.g. by a master shutdown, it sometimes gets
# into a state where it can't start emulators anymore. Work around this by
# not reusing Gradle daemons between runs
# (https://github.com/python/cpython/pull/155518#issuecomment-5259725142).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might copy/paste the comment rather than adding a link.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some details to the comment, but I think it's worth keeping the link in case any more details are added to the issue in the future.

test_environ = {"GRADLE_OPTS": "-Dorg.gradle.daemon=false"}

def setup(self, **kwargs):
android_py = ["python3", "Platforms/Android"]
self.addSteps([
Expand Down Expand Up @@ -1375,6 +1379,7 @@ def setup(self, **kwargs):
Test(
command=android_py + ["test", "--managed", "maxVersion", "-v", "--slow-ci"],
timeout=step_timeout(self.test_timeout),
env=self.test_environ,
),
])

Expand Down