In Android tests, disable Gradle daemon - #796
Conversation
vstinner
left a comment
There was a problem hiding this comment.
I don't know well Android. I don't know what is this -Dorg.gradle.daemon=false option. Does it disable a Gradle daemon? Maybe say it in the test_environ comment.
| """ | ||
|
|
||
| # Make each run more independent | ||
| # (https://github.com/python/cpython/pull/155518#issuecomment-5259725142). |
There was a problem hiding this comment.
You might copy/paste the comment rather than adding a link.
There was a problem hiding this comment.
I've added some details to the comment, but I think it's worth keeping the link in case any more details are added to the issue in the future.
vstinner
left a comment
There was a problem hiding this comment.
The change looks good to me, but I'm not an Android expert.
|
Should we backport the change (you didn't add the "backport" labels)? |
|
There are no backports in this repository, are there? |
|
Oh! I read quickly the PR, I saw |
|
Merged. Thanks for the long comment, its useful to me! |
This should fix the problem discussed at python/cpython#155518 (comment).