Build patch main - #249
Build patch main#249
Conversation
…rsions Vibe Cmaking is my specialty
How can you change the signature of a public method in your library used by literally everyone?
We don't provide any symbols, but at least we can build
Revision 19 of 447
Skill issue
We're using the CentOS 6 package, but whatever
|
Rather than a usual code review, please check whether I broke anything while cherry-picking or missed anything. |
There was a problem hiding this comment.
Pull Request Overview
This PR implements a build patch that introduces dummy symbol parser implementations, updates CMake configurations, and adds several CI workflows and documentation improvements. Key changes include adding placeholder implementations for ELF symbol parsing, significant updates to CMake find modules and options, and new GitHub workflows for building and testing wheels.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| libdebug/native/symbols/debug_sym_parser_dummy.cpp | Adds dummy placeholder implementations for reading ELF info and collecting external symbols. |
| libdebug/native/symbols/debug_sym_parser.h | Updates header file with adjusted copyright years and removed unused nanobind includes. |
| libdebug/native/symbols/debug_sym_parser.cpp | Updates the handling of demangled symbol names in add_symbol_info and removes Python binding module definitions. |
| cmake/* | Adds and updates multiple CMake scripts and modules for locating and configuring external libraries. |
| .github/workflows/* | Introduces workflows for building wheels and verifying distro compatibility. |
| docs/* | Updates documentation and build guides accordingly. |
| CMakeLists.txt | Updates the main project configuration to use imported targets and supports conditional builds. |
movdqu and vmodqu do the same thing, but only one works on SSE2
I'm tired, I need a vacation
No comment
|
Changelog 0.8.1
|
|
Not sure if we have other things to revert for this partial release |
|
@MrIndeciso I’d prefer not to revert them, but I’ll remove references to the wheel from the README and documentation, since the build instructions are really important in my opinion. |
Well we still have to put the installation requirements back on the front page and in the README, which those commits removed. |
I already did it, I was pushing while you were commenting :) |
No description provided.