Build system overhaul - #246
Closed
MrIndeciso wants to merge 45 commits into
Closed
MrIndeciso wants to merge 45 commits into
MrIndeciso wants to merge 45 commits into
Conversation
…rsions Vibe Cmaking is my specialty
How can you change the signature of a public method in your library used by literally everyone?
We don't provide any symbols, but at least we can build
MrIndeciso
force-pushed
the
enable-wheel-distrib
branch
17 times, most recently
from
May 27, 2025 19:25
22d7dee to
5bacd11
Compare
Revision 19 of 447
MrIndeciso
force-pushed
the
enable-wheel-distrib
branch
from
May 27, 2025 19:39
5bacd11 to
cbbb86a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR overhauls the build system for libdebug, implements changes to native ptrace bindings, introduces new symbol parsing modules with nanobind, and adds multiple scripts and workflows for building and testing wheels on various operating systems. Key changes include replacing tgkill with thread_kill in the ptrace binding code, restructuring the symbol parser module and its CMake configuration, and adding new CI workflows and platform‐specific wheel preparation scripts.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libdebug/ptrace/native/libdebug_ptrace_binding.cpp | Replaces direct use of tgkill with thread_kill and adds a new include for utils.h to support it. |
| libdebug/native/symbols/debug_sym_parser_shared.cpp | Modifies the add_symbol_info function to push both the demangled and original symbol entries. |
| CMakeLists.txt | Updates the project configuration to include new options for enabling/disabling libdwarf, libelf, and libiberty features and refactors targets and dependencies for the symbol parsing modules. |
| Various cmake and workflow scripts | Introduces new wheel distribution scripts for CentOS, Alpine, AlmaLinux and updates CI workflows for broader distro compatibility. |
Comments suppressed due to low confidence (3)
libdebug/native/symbols/debug_sym_parser_shared.cpp:31
- Consider expanding the comment to clarify the rationale for pushing both the demangled and the original symbol entries, so future maintainers understand that this duplication is intentional.
// We push both the demangled name and the original name
libdebug/ptrace/native/libdebug_ptrace_binding.cpp:207
- Ensure that the new function 'thread_kill' fully replicates the intended behavior of the previous 'tgkill' calls, including proper signal handling and error checking.
thread_kill(process_id, it->first, SIGSTOP);
.github/workflows/wheels.yml:88
- [nitpick] Verify that the repeated exclusions for 'alpine:3.22' with various Python versions are intentional and consider consolidating them for clarity in the workflow configuration.
- distro: alpine:3.22
MrIndeciso
force-pushed
the
enable-wheel-distrib
branch
from
June 1, 2025 11:44
e6e116f to
1041c1f
Compare
I'm not even sure why we're testing for this distro at this point
MrIndeciso
marked this pull request as ready for review
June 1, 2025 13:12
This was referenced Jun 1, 2025
MrIndeciso
force-pushed
the
enable-wheel-distrib
branch
2 times, most recently
from
June 1, 2025 20:45
a0d50eb to
b0d8044
Compare
Let's see how they perform now
MrIndeciso
force-pushed
the
enable-wheel-distrib
branch
from
June 1, 2025 21:07
b0d8044 to
7fe08d2
Compare
Member
|
Closing because cherry-picked in #249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.