Skip to content

feat: make the parameter compatibility mode banner actionable - #29456

Open
blinkagent[bot] wants to merge 1 commit into
mainfrom
blink/compat-mode-banner
Open

blinkagent[bot] wants to merge 1 commit into
mainfrom
blink/compat-mode-banner

Conversation

@blinkagent

@blinkagent blinkagent Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #29171, which added the compatibility_mode:true filter and linked the templates page banner to it.

The banner told admins that classic parameters were deprecated and pitched the dynamic parameters feature list. It did not say what happens if they ignore it, how much work the fix is, or use the same words as the setting they have to change.

Changes

  • Use the setting's name, parameter compatibility mode, instead of "classic parameters".
  • State the consequence: the legacy parameter flow will be removed in a future release.
  • State the effort: switching takes one click in the template's parameter settings.
  • Count-aware primary action. With more than one affected template it opens the compatibility_mode:true filter; with exactly one it links straight to that template's parameter settings and the title names the template.
  • Hide the banner when the compatibility mode filter is already applied, so the action is never a no-op that reloads the current view.
  • Drop prominent. A filled warning block reads as breakage; this is a migration task that stays visible until it is done.
  • Relabel the docs link from View docs to How to upgrade, deep-linked to a new section.
  • Docs: add Upgrade from parameter compatibility mode with the version requirements, the toggle location, the republish/refresh step, and the revert path. Also corrected the "all existing templates may be upgraded in-place" line, which read as though nothing was required of the operator.

Screenshots

Before:

before

After, multiple templates:

after

After, a single template:

after single

Testing

tsc and biome pass. Storybook stories are updated, including a new ClassicParameterFlowWarningHiddenWhileFiltering story, but browser-mode interaction tests could not run in my environment, so CI is their first run.

Created on behalf of @matifali

Aligns the templates page banner with the renamed parameter compatibility mode setting, states that the mode will be removed, and points admins at the fix instead of at a feature pitch.
@github-actions

Copy link
Copy Markdown
Contributor

Docs preview

Check off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here.

@github-actions github-actions Bot added the community Pull Requests and issues created by the community. label Sep 17, 2026
@blinkagent blinkagent Bot removed the community Pull Requests and issues created by the community. label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant