feat: make the parameter compatibility mode banner actionable - #29456
Open
blinkagent[bot] wants to merge 1 commit into
Open
blinkagent[bot] wants to merge 1 commit into
blinkagent[bot] wants to merge 1 commit into
Conversation
Aligns the templates page banner with the renamed parameter compatibility mode setting, states that the mode will be removed, and points admins at the fix instead of at a feature pitch.
Contributor
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #29171, which added the
compatibility_mode:truefilter and linked the templates page banner to it.The banner told admins that classic parameters were deprecated and pitched the dynamic parameters feature list. It did not say what happens if they ignore it, how much work the fix is, or use the same words as the setting they have to change.
Changes
compatibility_mode:truefilter; with exactly one it links straight to that template's parameter settings and the title names the template.prominent. A filled warning block reads as breakage; this is a migration task that stays visible until it is done.View docstoHow to upgrade, deep-linked to a new section.Screenshots
Before:
After, multiple templates:
After, a single template:
Testing
tscandbiomepass. Storybook stories are updated, including a newClassicParameterFlowWarningHiddenWhileFilteringstory, but browser-mode interaction tests could not run in my environment, so CI is their first run.Created on behalf of @matifali