Skip to content

feat: filter templates using classic parameters - #29171

Merged
jakehwll merged 5 commits into
mainfrom
jakehwll/classic-template-filter
Sep 17, 2026
Merged

feat: filter templates using classic parameters#29171
jakehwll merged 5 commits into
mainfrom
jakehwll/classic-template-filter

Conversation

@jakehwll

@jakehwll jakehwll commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 This PR was modified by Coder Agents on behalf of Jake Howell.

Adds a compatibility-mode template filter and exposes it as a templates page preset.

The classic parameters warning now links administrators to the filtered template list so they can identify and update affected templates.

@jakehwll
jakehwll requested a review from aslilac September 11, 2026 04:55
@jakehwll
jakehwll marked this pull request as ready for review September 11, 2026 04:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-11T04:58:38.944130Z b3cbb9f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderagents

coderagents Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Documentation Check

Updates Needed

  • docs/admin/templates/creating-templates.md - The Templates list page has new user-facing surfaces that are not documented anywhere: (1) a new filter preset "Templates using classic parameters" (search query compatibility-mode:true) added to the templates filter menu, and (2) a "View templates" button added to the existing "classic parameters are deprecated" warning alert. The agents-allowed search filter is documented on docs/ai-coder/agents/platform-controls/index.md, but this admin-facing filter is not covered by any existing page and is not agent-specific.
  • docs/ai-coder/agents/platform-controls/index.md - A new templates search-query filter compatibility-mode was added (maps to the UseClassicParameterFlow query param). Not agent-specific, but this page is the one place in the docs that documents the templates search filter (agents-allowed:false), so it is the natural home to record the new compatibility-mode parameter and its true/false/unset semantics.

New Documentation Needed

  • docs/admin/templates/managing-templates/index.md (or a templates how-to page) - Consider documenting the Templates list filters/presets, since this filter is admin-facing and not covered by platform-controls/index.md. This is not strictly required if the above two items are addressed.

Automated review via Coder Agents

aslilac
aslilac reviewed Sep 15, 2026
View reviewed changes
Comment thread coderd/searchquery/search.go Outdated
Comment thread site/src/pages/TemplatesPage/TemplatesFilter.tsx Outdated
Comment thread site/src/pages/TemplatesPage/TemplatesPageView.test.tsx Outdated
@jakehwll
jakehwll requested a review from aslilac September 15, 2026 01:47
@jakehwll
jakehwll merged commit d671150 into main Sep 17, 2026
28 checks passed
@jakehwll
jakehwll deleted the jakehwll/classic-template-filter branch September 17, 2026 01:11
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aslilac aslilac aslilac approved these changes

Assignees

@jakehwll jakehwll

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakehwll @aslilac