Skip to content

Move dependencies to workspace for literal crate#7739

Merged
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-literal
Apr 30, 2026
Merged

Move dependencies to workspace for literal crate#7739
youknowone merged 2 commits into
RustPython:mainfrom
fanninpm:move-deps-to-workspace-for-literal

Conversation

@fanninpm
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm commented Apr 30, 2026 •
edited by coderabbitai Bot
Loading

cc @ShaharNaveh

Summary by CodeRabbit

  • Chores
    • Updated internal dependency management configuration to improve consistency across the project build process.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: a3d9e228-050f-490e-8955-2d57c11ff7b8

📥 Commits

Reviewing files that changed from the base of the PR and between 6e895fb and af4f36e.

📒 Files selected for processing (2)
  • Cargo.toml
  • crates/literal/Cargo.toml
📝 Walkthrough

Walkthrough

Adds two new workspace-level dependencies (hexf-parse and lexical-parse-float) to the root Cargo.toml, then updates crates/literal/Cargo.toml to reference these dependencies via workspace = true instead of hardcoding versions.

Changes

Cohort / File(s) Summary
Workspace Dependencies
Cargo.toml		 Added hexf-parse and lexical-parse-float to [workspace.dependencies] with pinned versions.
Literal Crate Dependencies
crates/literal/Cargo.toml		 Updated hexf-parse and lexical-parse-float dependencies to use workspace = true, maintaining existing ["format"] feature for lexical-parse-float.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • ShaharNaveh

Poem

🐰 Dependencies now share one home so bright,
No more version duplicates cluttering sight,
hexf-parse and lexical find their place,
Workspace harmony—organized with grace! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: moving dependencies to the workspace for the literal crate, which is exactly what the Cargo.toml modifications show.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@youknowone youknowone enabled auto-merge (squash) April 30, 2026 02:01
ShaharNaveh
ShaharNaveh approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@youknowone youknowone merged commit 88be7bb into RustPython:main Apr 30, 2026
20 checks passed
@fanninpm fanninpm deleted the move-deps-to-workspace-for-literal branch May 1, 2026 01:49
This was referenced May 1, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fanninpm @ShaharNaveh @youknowone