Skip to content

Move dependencies to workspace for derive-impl crate#7710

Merged
youknowone merged 2 commits intoRustPython:mainfrom
fanninpm:move-deps-to-workspace-for-derive-impl
Apr 28, 2026
Merged

Move dependencies to workspace for derive-impl crate#7710
youknowone merged 2 commits intoRustPython:mainfrom
fanninpm:move-deps-to-workspace-for-derive-impl

Conversation

@fanninpm
Copy link
Copy Markdown
Contributor

@fanninpm fanninpm commented Apr 28, 2026 •
edited by coderabbitai Bot
Loading

cc @ShaharNaveh

Summary by CodeRabbit

  • Chores
    • Added three workspace-level dependencies and updated crate dependency declarations to reference the workspace versions for consistent dependency management across the workspace.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 8bda4bde-423d-42aa-804a-39bc42f01d16

📥 Commits

Reviewing files that changed from the base of the PR and between 1aae389 and c7b903f.

📒 Files selected for processing (2)
  • Cargo.toml
  • crates/derive-impl/Cargo.toml
✅ Files skipped from review due to trivial changes (2)
  • Cargo.toml
  • crates/derive-impl/Cargo.toml
📝 Walkthrough

Walkthrough

Workspace Cargo.toml gains three shared dependencies (maplit, syn-ext, textwrap); crates/derive-impl/Cargo.toml switches those dependencies to workspace = true while keeping existing feature flags.

Changes

Cohort / File(s) Summary
Workspace dependency configuration
Cargo.toml		 Added workspace-level dependencies: maplit = "1.0.2", syn-ext = "0.5.0", and textwrap = { version = "0.16.2", default-features = false }.
Workspace dependency consumption
crates/derive-impl/Cargo.toml		 Switched maplit, syn-ext, and textwrap to workspace = true; preserved syn-ext's features = ["full"] and textwrap's default-features = false.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 I hopped through Cargo, tidy and spry,
Three crates now shared beneath one sky,
Versions centralized, no scattered trail,
Features kept snug in the workspace veil,
🥕📦✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: moving three dependencies (maplit, syn-ext, textwrap) to workspace configuration for the derive-impl crate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Cargo.toml`:
- Line 200: Update the workspace dependency entry for textwrap to the patch
release 0.16.2: locate the textwrap = "0.16.1" declaration in the workspace
Cargo.toml and change it to textwrap = "0.16.2", then run cargo update -p
textwrap (or cargo update) to refresh the lockfile; ensure this sits alongside
the existing maplit = "1.0.2" and syn-ext entries so Dependabot can manage
updates from the workspace root.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 835ccfab-6532-41e5-8251-1cca1b736d75

📥 Commits

Reviewing files that changed from the base of the PR and between 1d42ee5 and 1aae389.

📒 Files selected for processing (2)
  • Cargo.toml
  • crates/derive-impl/Cargo.toml

Comment thread Cargo.toml
@fanninpm
Copy link
Copy Markdown
Contributor Author

fanninpm commented Apr 28, 2026 •
edited
Loading

@ShaharNaveh why is CI failing? Nevermind; I fixed it.

@fanninpm fanninpm force-pushed the move-deps-to-workspace-for-derive-impl branch from 1aae389 to c7b903f Compare April 28, 2026 02:43
ShaharNaveh
ShaharNaveh approved these changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 363d198 into RustPython:main Apr 28, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@youknowone youknowone youknowone approved these changes

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fanninpm @youknowone @ShaharNaveh