Skip to content

Tighten strict handling for canary CI #3509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
C-Achard merged 1 commit into from
Sep 14, 2026
+19 −4
Merged

Tighten strict handling for canary CI #3509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/intelligent-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ jobs:
"examples/testscript_pytorch_multi_animal.py"
]
continue_on_error: true
# Per-id `strict` only (failure only on pushes and same-repo PRs)
# Fork PRs stay continue-on-error, so an external contributor is not blocked
strict_cells: ${{ github.event_name == 'push' ||
github.event.pull_request.head.repo.full_name == github.repository }}

tf-install-smoke-test:
name: TensorFlow install smoke test
Expand Down
19 changes: 15 additions & 4 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ on:
required: false
type: boolean
default: false
strict_cells:
required: false
type: boolean
default: true

workflow_dispatch:
inputs:
Expand Down Expand Up @@ -67,6 +71,11 @@ on:
required: false
type: boolean
default: false
strict_cells:
description: "Make canary lane checks strict (set false for non-blocking behavior)"
required: false
type: boolean
default: true

jobs:
build:
Expand Down Expand Up @@ -219,7 +228,7 @@ jobs:

- name: Run pytest
id: run_pytest
continue-on-error: ${{ inputs.continue_on_error }}
continue-on-error: ${{ inputs.continue_on_error && !(inputs.strict_cells && matrix.strict == 'true') }}
shell: bash -el {0}
env:
FULL_SUITE: ${{ inputs.full_suite }}
Expand Down Expand Up @@ -249,7 +258,7 @@ jobs:

- name: Run functional scripts
id: run_functional_scripts
continue-on-error: ${{ inputs.continue_on_error }}
continue-on-error: ${{ inputs.continue_on_error && !(inputs.strict_cells && matrix.strict == 'true') }}
shell: bash -el {0}
env:
FULL_SUITE: ${{ inputs.full_suite }}
Expand Down Expand Up @@ -295,10 +304,12 @@ jobs:
- name: Report continue-on-error failures
# continue-on-error hides failures behind a small icon on the step itself and
# reports the job as passing overall, so make failures hard to miss: emit a
# workflow annotation and a job-summary entry whenever this happens.
# workflow annotation and a job summary entry whenever this happens. Strict
# cells fail the job outright, so they need no annotation.
if: >-
${{ inputs.continue_on_error &&
${{ inputs.continue_on_error && !(inputs.strict_cells && matrix.strict == 'true') &&
(steps.run_pytest.outcome == 'failure' || steps.run_functional_scripts.outcome == 'failure') }}

shell: bash
run: |
MATRIX_DESC="${{ matrix.os }}, py${{ matrix.python-version }}, pip_overrides='$PIP_OVERRIDES'"
Expand Down
Loading