Tighten strict handling for canary CI - #3509
Merged
Merged
Conversation
C-Achard
added this pull request to stack #3511
September 11, 2026 12:53
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain.
Pull request overview
Adds configurable strict handling for selected canary CI lanes while keeping fork PR checks non-blocking.
Changes:
- Adds the
strict_cellsworkflow input. - Applies strict behavior to
matrix.strictlanes. - Suppresses redundant annotations for failing strict lanes.
File summaries
| File | Summary |
|---|---|
.github/workflows/python-package.yml |
Defines and applies strict-cell behavior. |
.github/workflows/intelligent-testing.yml |
Enables strict canary behavior for trusted events. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
C-Achard
marked this pull request as ready for review
September 11, 2026 13:07
C-Achard
force-pushed
the
cy/more-granular-canary
branch
from
September 11, 2026 14:19
2ac2947 to
bc6d9b7
Compare
Collaborator
Author
|
@deruyter92 I can also (and would like to) integrate the canary lane more closely to the test selector, so it runs only on deps changes. Do you think that would be interesting? |
C-Achard
added a commit
that referenced
this pull request
Sep 14, 2026
C-Achard
force-pushed
the
cy/more-granular-canary
branch
from
September 14, 2026 09:29
bc6d9b7 to
a12c9c6
Compare
deruyter92
removed this pull request from stack #3511
September 14, 2026 09:38
deruyter92
added this pull request to stack #3515
September 14, 2026 09:38
deruyter92
approved these changes
Sep 14, 2026
deruyter92
left a comment
Collaborator
There was a problem hiding this comment.
Good PR thanks for adding this! No changes needed IMO, besides a stray numpy upper bound that I think is from an old base maybe
Add a `strict_cells` workflow input and use it to make only `matrix.strict` canary lanes fail the job outright. The intelligent testing workflow now enables strict cells for pushes and same-repo PRs while keeping fork PRs non-blocking, and the reporting step skips annotations for lanes that already fail normally.
deruyter92
force-pushed
the
cy/more-granular-canary
branch
from
September 14, 2026 11:36
ddace9a to
d476967
Compare
deruyter92
removed this pull request from stack #3515
September 14, 2026 11:38
deruyter92
changed the base branch from
jaap/release-dependency-upper-bounds
to
cy/fix-numpy2-unpin-issues
September 14, 2026 11:38
deruyter92
added this pull request to stack #3516
September 14, 2026 11:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
strict_cellsworkflow input and use it to make onlymatrix.strictcanary lanes fail the job outright.The intelligent testing workflow now lets one define strict canary checks for pushes and same-repo PRs while keeping fork PRs non-blocking, and the reporting step skips annotations for lanes that already fail on strict.
A global toggle is kept if needed.
Note that the "resolve" jobs I added in #3499 may not be needed anymore depending on how we change the full test CI to include tf (and therefore np1) or not and how.
The goal is anyways to provide more flexibility in checks, which should be useful even if the exact jobs do not remain (esp. since #3499 and associated should make some of them irrelevant already).