fix for #1507 - mac signing issues for release builds#1510
Open
kjhollen wants to merge 1 commit intoprocessing:mainfrom
Open
fix for #1507 - mac signing issues for release builds#1510kjhollen wants to merge 1 commit intoprocessing:mainfrom
kjhollen wants to merge 1 commit intoprocessing:mainfrom
Conversation
fixes issue with Mac app notarization failure by signing the whole app again after fileAssocations are made. previously, release builds were failing because the .icns files for .pde, .pdex, and .pdez were added to the .app file after signing.
Stefterv
approved these changes
Apr 27, 2026
Member
|
It ain't pretty, but if it works, it works! I created a release here to test if it works in the CI: https://github.com/Stefterv/processing4/releases/tag/processing-1448-4.5.18 And yes, notarisation always takes around 15-25 minutes Looks like it works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #1507 with Mac app notarization failure by signing the whole app again after fileAssocations are made. Adds an extra step called 'signApp' to the build process for
./gradlew -m packageDistributionForCurrentOSwhich depends oncreateDistributableandsetExecutablePermissions.Previously, release builds were failing because the .icns files for .pde, .pdex, and .pdez were added to the .app file after signing, when
fileAssocationwas called innativeDistributions.Most of this code was generated with Copilot, then I edited it for legibility. I asked Copilot a lot of questions about the order of operations for the build system and where the fileAssociations occurred, and feel confident that this is the right place in the process to re-sign the app. I also prodded Copilot to see if there were any other simpler options that didn't involve signing things a second time (outside of when jpackage does this automatically), but wasn't able to produce any other successful solutions.
I have only tested this on Mac, but the file type associations work and the app notarization completed successfully (though it took nearly 30 minutes to run the notarization).
pinging @catilac for review!