util: fix numericSeparator handling for scientific notation#62983
Open
Fifixex wants to merge 1 commit intonodejs:mainfrom
Open
util: fix numericSeparator handling for scientific notation#62983Fifixex wants to merge 1 commit intonodejs:mainfrom
Fifixex wants to merge 1 commit intonodejs:mainfrom
Conversation
ljharb
approved these changes
Apr 27, 2026
lpinca
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes incorrect behavior in
util.inspectwhennumericSeparatoris enabled and the input number is represented in scientific notation (e.g.1e-7or1e+21).Previously, scientific notation strings were incorrectly processed by the numeric separator logic, which assumes the presence of a decimal point. This led to malformed output such as:
'1e-.1e-_7'The issue occurs because the formatting logic attempts to split the numeric string at a decimal point (
.), which does not exist in scientific notation. As a result, incorrect string slicing is applied. This change adds a guard for scientific notation strings, ensuring they are returned without applying numeric separator formatting. It also fixes the case where no decimal point exists by treating the value as a plain number string.Closes: #62981