Skip to content

dgram: support UV_UDP_LINUX_RECVERR for udp#62971

Draft
theanarkh wants to merge 1 commit intonodejs:mainfrom
theanarkh:add_UV_UDP_LINUX_RECVERR_flag
Draft

dgram: support UV_UDP_LINUX_RECVERR for udp#62971
theanarkh wants to merge 1 commit intonodejs:mainfrom
theanarkh:add_UV_UDP_LINUX_RECVERR_flag

Conversation

@theanarkh
Copy link
Copy Markdown
Contributor

@theanarkh theanarkh commented Apr 26, 2026 •
edited
Loading

Previously, it was impossible to know whether the data packet had reached the other end successfully. This PR add a flag to support this.

Error: recvmsg ECONNREFUSED
    at UDP.onMessage [as onmessage] (node:dgram:988:31) {
  errno: -111,
  code: 'ECONNREFUSED',
  syscall: 'recvmsg'
}
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 26, 2026

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels Apr 26, 2026
@theanarkh theanarkh force-pushed the add_UV_UDP_LINUX_RECVERR_flag branch 2 times, most recently from dbaad87 to d9eaa68 Compare April 26, 2026 15:28
@theanarkh theanarkh force-pushed the add_UV_UDP_LINUX_RECVERR_flag branch from d9eaa68 to 460b053 Compare April 26, 2026 15:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (c202696) to head (460b053).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #62971   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         706      706           
  Lines      219416   219414    -2     
  Branches    42073    42077    +4     
=======================================
  Hits       196738   196738           
  Misses      14576    14576           
+ Partials     8102     8100    -2
Files with missing lines Coverage Δ
lib/dgram.js 97.46% <100.00%> (+<0.01%) ⬆️
src/udp_wrap.cc 78.83% <100.00%> (+0.62%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theanarkh theanarkh marked this pull request as draft April 26, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theanarkh @nodejs-github-bot