pubsub: delete deprecated code#1771
Merged
pongad merged 3 commits intogoogleapis:masterfrom Mar 23, 2017
pongad:del-deprecated
Merged
pubsub: delete deprecated code#1771pongad merged 3 commits intogoogleapis:masterfrom pongad:del-deprecated
pongad merged 3 commits intogoogleapis:masterfrom
pongad:del-deprecated
Conversation
Two integration tests are moved over to new code to make sure the library isn't dead on arrival. Fixes #1760.
Contributor
Author
|
@garrettjonesgoogle I wanted to make sure I'm not being too nuke happy. I deleted both As discussed before, I have doubts about the usefulness of these classes, but they are advertised in the README. I think the best course of action is
Please let me know what you think. |
Contributor
garrettjonesgoogle
left a comment
There was a problem hiding this comment.
LGTM.
I filed an issue to fix TESTING.md separately: #1789
| } | ||
| Policy policy = publisherClient.getIamPolicy(topicName.toString()); | ||
| Binding binding = | ||
| Binding.newBuilder().setRole("roles/viewer").addMembers("allAuthenticatedUsers").build(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Changes Unknown when pulling dbfc07e on pongad:del-deprecated into ** on GoogleCloudPlatform:master**. |
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
…v6.77.0 (googleapis#1771) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner-bom](https://redirect.github.com/googleapis/java-spanner) | `6.76.0` -> `6.77.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner-bom)</summary> ### [`v6.77.0`](https://redirect.github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6770-2024-10-02) [Compare Source](https://redirect.github.com/googleapis/java-spanner/compare/v6.76.0...v6.77.0) ##### Features - Add INTERVAL API ([c078ac3](https://redirect.github.com/googleapis/java-spanner/commit/c078ac34c3d14b13bbd4a507de4f0013975dca4e)) ##### Dependencies - Update dependency com.google.api.grpc:proto-google-cloud-monitoring-v3 to v3.52.0 ([#&googleapis#8203;3291](https://redirect.github.com/googleapis/java-spanner/issues/3291)) ([9241063](https://redirect.github.com/googleapis/java-spanner/commit/92410638b0ba88f8e89e28bd12dd58830f7aaeb3)) - Update dependency com.google.cloud:google-cloud-monitoring to v3.52.0 ([#&googleapis#8203;3292](https://redirect.github.com/googleapis/java-spanner/issues/3292)) ([da27a19](https://redirect.github.com/googleapis/java-spanner/commit/da27a1992e40b1b4591f0232f687d8031387e749)) - Update dependency com.google.cloud:google-cloud-monitoring to v3.52.0 ([#&googleapis#8203;3293](https://redirect.github.com/googleapis/java-spanner/issues/3293)) ([c6dbdb2](https://redirect.github.com/googleapis/java-spanner/commit/c6dbdb255eb4cd231a2dc7cef94bf3353fa7e837)) - Update dependency com.google.cloud:google-cloud-trace to v2.51.0 ([#&googleapis#8203;3294](https://redirect.github.com/googleapis/java-spanner/issues/3294)) ([a269747](https://redirect.github.com/googleapis/java-spanner/commit/a269747889ea0b2380f07e1efef3b288a9c4fd04)) - Update dependency com.google.cloud:sdk-platform-java-config to v3.36.1 ([#&googleapis#8203;3355](https://redirect.github.com/googleapis/java-spanner/issues/3355)) ([5191e71](https://redirect.github.com/googleapis/java-spanner/commit/5191e71a83a316b41564ce2604980c8f33135f2f)) - Update dependency com.google.cloud.opentelemetry:exporter-metrics to v0.32.0 ([#&googleapis#8203;3371](https://redirect.github.com/googleapis/java-spanner/issues/3371)) ([d5b5ca0](https://redirect.github.com/googleapis/java-spanner/commit/d5b5ca0cccc6cf73d759245d2bd72f33c7d39830)) - Update dependency com.google.cloud.opentelemetry:exporter-trace to v0.32.0 ([#&googleapis#8203;3372](https://redirect.github.com/googleapis/java-spanner/issues/3372)) ([aa9a71d](https://redirect.github.com/googleapis/java-spanner/commit/aa9a71d38dabd8d1974bb553761e93735ade5c26)) - Update dependency commons-io:commons-io to v2.17.0 ([#&googleapis#8203;3349](https://redirect.github.com/googleapis/java-spanner/issues/3349)) ([7c21164](https://redirect.github.com/googleapis/java-spanner/commit/7c21164f2b8e75afab268f2fb8e132a372ac0d67)) - Update dependency io.opentelemetry:opentelemetry-bom to v1.42.1 ([#&googleapis#8203;3323](https://redirect.github.com/googleapis/java-spanner/issues/3323)) ([95dfc02](https://redirect.github.com/googleapis/java-spanner/commit/95dfc02ae2d65f99219dcced66cf4e74d1c4975b)) - Update dependency ubuntu to v24 ([#&googleapis#8203;3356](https://redirect.github.com/googleapis/java-spanner/issues/3356)) ([042c294](https://redirect.github.com/googleapis/java-spanner/commit/042c294cc5f83eebd2e3600cffb165e5b467d63e)) - Update googleapis/sdk-platform-java action to v2.46.1 ([#&googleapis#8203;3354](https://redirect.github.com/googleapis/java-spanner/issues/3354)) ([378f5cf](https://redirect.github.com/googleapis/java-spanner/commit/378f5cfb08d4e5ee80b21007bfc829de61bfbdbe)) - Update junixsocket.version to v2.10.1 ([#&googleapis#8203;3367](https://redirect.github.com/googleapis/java-spanner/issues/3367)) ([5f94915](https://redirect.github.com/googleapis/java-spanner/commit/5f94915941c4e4132f8460a04dde0643fa63ab99)) - Update opentelemetry.version to v1.42.1 ([#&googleapis#8203;3330](https://redirect.github.com/googleapis/java-spanner/issues/3330)) ([7b05e43](https://redirect.github.com/googleapis/java-spanner/commit/7b05e4301953364617691e8ae225cea823e3a323)) ##### Documentation - Update comment for PROFILE QueryMode ([c078ac3](https://redirect.github.com/googleapis/java-spanner/commit/c078ac34c3d14b13bbd4a507de4f0013975dca4e)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/java-spanner-jdbc). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two integration tests are moved over to new code
to make sure the library isn't dead on arrival.