Skip to content

docs(docs-infra): Signal forms custom validator with 'fieldTree' fiel…#66772

Merged
AndrewKushnir merged 1 commit intoangular:mainfrom
aparzi:update-docs-issue-66687
Feb 6, 2026
Merged

docs(docs-infra): Signal forms custom validator with 'fieldTree' fiel…#66772
AndrewKushnir merged 1 commit intoangular:mainfrom
aparzi:update-docs-issue-66687

Conversation

@aparzi
Copy link
Copy Markdown
Contributor

@aparzi aparzi commented Jan 27, 2026

Signal forms custom validator with 'fieldTree' field in validation result error
Update docs for fieldTree property

fixes #66687

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

Issue Number: #66687

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove Bot requested a review from mmalerba January 27, 2026 10:13
@angular-robot angular-robot Bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Jan 27, 2026
@ngbot ngbot Bot added this to the Backlog milestone Jan 27, 2026
Comment thread adev/src/content/guide/forms/signals/validation.md Outdated
Comment thread adev/src/content/guide/forms/signals/validation.md Outdated
@aparzi aparzi force-pushed the update-docs-issue-66687 branch from 5e285b0 to 682fb2b Compare January 27, 2026 10:38
@aparzi aparzi requested a review from JeanMeche January 27, 2026 10:39
Comment thread adev/src/content/guide/forms/signals/validation.md Outdated
Comment thread adev/src/content/guide/forms/signals/validation.md Outdated
Comment thread adev/src/content/guide/forms/signals/validation.md Outdated
@aparzi aparzi force-pushed the update-docs-issue-66687 branch from 682fb2b to befbf8a Compare January 27, 2026 13:16
@aparzi aparzi requested a review from JeanMeche January 27, 2026 13:21
@kirjs kirjs self-assigned this Jan 27, 2026
@kirjs kirjs self-requested a review January 27, 2026 14:15
Comment thread adev/src/content/guide/forms/signals/validation.md
@aparzi aparzi force-pushed the update-docs-issue-66687 branch from befbf8a to b99e75a Compare January 27, 2026 15:55
@aparzi
Copy link
Copy Markdown
Contributor Author

aparzi commented Jan 27, 2026

PR updated

Comment thread adev/src/content/guide/forms/signals/validation.md Outdated
Comment thread adev/src/content/guide/forms/signals/validation.md
@aparzi aparzi force-pushed the update-docs-issue-66687 branch from b99e75a to 5a603ea Compare January 31, 2026 11:41
@aparzi aparzi requested a review from leonsenft January 31, 2026 11:41
@aparzi aparzi closed this Jan 31, 2026
@aparzi aparzi force-pushed the update-docs-issue-66687 branch from 5a603ea to 8d5210c Compare January 31, 2026 11:44
@aparzi aparzi reopened this Jan 31, 2026
@aparzi aparzi force-pushed the update-docs-issue-66687 branch from 3b4251c to ee1ae83 Compare February 2, 2026 14:28
Comment thread adev/src/content/guide/forms/signals/validation.md
@aparzi aparzi force-pushed the update-docs-issue-66687 branch from ee1ae83 to 5c79a18 Compare February 4, 2026 09:10
@aparzi aparzi requested a review from leonsenft February 4, 2026 09:10
@JeanMeche
Copy link
Copy Markdown
Member

To capture a discussion we had, we should consider a more meaningful example.
The current one works, but there’s likely a better way to illustrate the feature.

Copy link
Copy Markdown
Contributor

@leonsenft leonsenft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the lint failure.

Comment thread adev/src/content/guide/forms/signals/validation.md Outdated
@aparzi aparzi requested a review from leonsenft February 5, 2026 11:17
@leonsenft
Copy link
Copy Markdown
Contributor

The correct commit type is just docs::

docs-infra: used for infrastructure changes to the docs-app (angular.dev) within the /adev directory, such as application code, tooling, or configuration. For modifications to documentation content (e.g., editing a .md file), use docs: without a scope instead.

https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md#-scope

@leonsenft leonsenft added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 5, 2026
@aparzi aparzi force-pushed the update-docs-issue-66687 branch 3 times, most recently from 9986881 to c9121fb Compare February 5, 2026 20:22
@aparzi aparzi requested a review from leonsenft February 5, 2026 20:24
@aparzi aparzi requested a review from leonsenft February 5, 2026 22:13
…ion result error

Update docs for fieldTree property

fixes angular#66687
@aparzi aparzi force-pushed the update-docs-issue-66687 branch from 1e9208e to d8f0222 Compare February 6, 2026 09:11
@leonsenft leonsenft added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 6, 2026
@AndrewKushnir AndrewKushnir added the target: patch This PR is targeted for the next patch release label Feb 6, 2026
@AndrewKushnir AndrewKushnir merged commit 63d828a into angular:main Feb 6, 2026
18 of 20 checks passed
@AndrewKushnir
Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signal forms custom validator with 'fieldTree' field in validation result error

6 participants