Skip to content

Update IsActiveMatchOptions requirements#66764

Merged
leonsenft merged 2 commits intoangular:mainfrom
atscott:defaultisactive
Jan 29, 2026
Merged

Update IsActiveMatchOptions requirements#66764
leonsenft merged 2 commits intoangular:mainfrom
atscott:defaultisactive

Conversation

@atscott
Copy link
Copy Markdown
Contributor

@atscott atscott commented Jan 26, 2026

See individual commits

@atscott
feat(router): Make match options optional in isActive
72d6fb9 
The behavior now matches RouterLinkActive.
@atscott atscott requested a review from MarkTechson January 26, 2026 23:31
@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: router labels Jan 26, 2026
@ngbot ngbot Bot added this to the Backlog milestone Jan 26, 2026
JeanMeche
JeanMeche approved these changes Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@atscott atscott added the target: minor This PR is targeted for the next minor release label Jan 27, 2026
SkyZeroZx
SkyZeroZx reviewed Jan 27, 2026
View reviewed changes
Comment thread packages/router/src/url_tree.ts
@atscott
feat(router): Update IsActiveMatchOptions APIs to accept a Partial
ffe6974 
This updates `RouterLinkActive`, `Router.isActive`, and the standalone
`isActive` function to accept `Partial<IsActiveMatchOptions>` which uses
the current default values as the base (paths and queryParams are
subset, fragment and matrix params are ignored).

fixes angular#53326
MarkTechson
MarkTechson approved these changes Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@MarkTechson MarkTechson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for doing this, Andrew!

@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jan 29, 2026
@leonsenft leonsenft merged commit 907a94d into angular:main Jan 29, 2026
20 checks passed
@leonsenft
Copy link
Copy Markdown
Contributor

leonsenft commented Jan 29, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Mar 1, 2026

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@MarkTechson MarkTechson MarkTechson approved these changes

+1 more reviewer

@SkyZeroZx SkyZeroZx SkyZeroZx left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: router detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@atscott @leonsenft @JeanMeche @MarkTechson @SkyZeroZx