Remove TS plugin-related codes#66758
Closed
atscott wants to merge 2 commits intoangular:mainfrom
Closed
Conversation
This removes the 'angularOnly' config option from the language service package. This option was there to support the traditional decorator/proxy plugin pattern for TS. We never used this though and it is not a pattern that will be supported in TS 7+ (see microsoft/typescript-go#455 (reply in thread))
This plugin factory was an attempt to resolve the renaming issue where a rename provider could not be effectively prioritized. It was partially reverted because it broke several things. In addition, this plugin pattern will not be supported in the TS 7+ architecture.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes 'angularOnly' and plugin factory meant to be used with the "decorator pattern" plugins that extend TSServer functionality.