refactor(router): update routerlinkActive internals to use signals#66728
Closed
atscott wants to merge 2 commits intoangular:mainfrom
Closed
refactor(router): update routerlinkActive internals to use signals#66728atscott wants to merge 2 commits intoangular:mainfrom
atscott wants to merge 2 commits intoangular:mainfrom
Conversation
36d7642 to
45afc09
Compare
This update makes use of the fact that RouterLink now uses signals, so RouterLinkActive can make reactive computations based on those values rather than using an rxjs subscription to watch for changes.
45afc09 to
e2f14b3
Compare
Contributor
|
This draft PR is being closed because it has been stale for 28 days and has seen no activity from you. If you'd like to see this change land, you can re-open this PR. Thank you for being an Angular contributor! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update makes use of the fact that RouterLink now uses signals, so RouterLinkActive can make reactive computations based on those values rather than using an rxjs subscription to watch for changes.