Skip to content

fix: make the nightly hypothesis failure alarm able to file issues - #4274

Merged
d-v-b merged 1 commit into
zarr-developers:mainfrom
glaziermag:fix-nightly-hypothesis-alarm
Aug 20, 2026
Merged

fix: make the nightly hypothesis failure alarm able to file issues#4274
d-v-b merged 1 commit into
zarr-developers:mainfrom
glaziermag:fix-nightly-hypothesis-alarm

Conversation

@glaziermag

@glaziermag glaziermag commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #4273. The nightly hypothesis workflow's failure-reporting step has never been able to file its "Nightly Hypothesis tests failed" issue. Three small changes make it work:

  • Write the report log the action reads: pytest-reportlog added to the test dependency group and --report-log passed via PYTEST_ADDOPTS on the test step (the reporting step was adapted from xarray, where the pytest invocation carries this flag).
  • Grant the job issues: write: the workflow-level contents: read from Limit privilege escalation and token theft in workflows #3742 leaves the token unable to create issues; this uses the same job-level pattern as links.yml and issue-metrics.yml, whose auto-issues do land.
  • Use the existing automated issue label: the configured topic-hypothesis label doesn't exist, and gh issue new errors on unknown labels rather than creating them. automated issue is what the Link Checker reports already use.

Demonstrated on a fork at this exact configuration: a forced nightly-style failure auto-files the issue (runauto-created issue, label applied), and the suite stays green with reportlog enabled (run).

Prepared with Claude (AI) and submitted at my direction, per the invitation on #4273.

For reviewers

Two choices you may want differently: a dedicated topic-hypothesis label instead of reusing automated issue (it would need creating before merge), and whether the flag should live in the run-hypothesis hatch script rather than PYTEST_ADDOPTS on the workflow step.

Author attestation

  • I am a human, these are my changes, and I have reviewed and understood every change and can explain why each is correct.

TODO

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label Aug 19, 2026
@d-v-b

d-v-b commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

lgtm

Two choices you may want differently: a dedicated topic-hypothesis label instead of reusing automated issue (it would need creating before merge), and whether the flag should live in the run-hypothesis hatch script rather than PYTEST_ADDOPTS on the workflow step.

we can deal with this later

@d-v-b
d-v-b merged commit 20ba31e into zarr-developers:main Aug 20, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The "Nightly Hypothesis tests failed" auto-issue has never been filed: all 30 retained nightly failures died in the report step

2 participants