fix: make the nightly hypothesis failure alarm able to file issues - #4274
Merged
d-v-b merged 1 commit intoAug 20, 2026
Merged
Conversation
Contributor
|
lgtm
we can deal with this later |
d-v-b
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4273. The nightly hypothesis workflow's failure-reporting step has never been able to file its "Nightly Hypothesis tests failed" issue. Three small changes make it work:
pytest-reportlogadded to thetestdependency group and--report-logpassed viaPYTEST_ADDOPTSon the test step (the reporting step was adapted from xarray, where the pytest invocation carries this flag).issues: write: the workflow-levelcontents: readfrom Limit privilege escalation and token theft in workflows #3742 leaves the token unable to create issues; this uses the same job-level pattern aslinks.ymlandissue-metrics.yml, whose auto-issues do land.automated issuelabel: the configuredtopic-hypothesislabel doesn't exist, andgh issue newerrors on unknown labels rather than creating them.automated issueis what the Link Checker reports already use.Demonstrated on a fork at this exact configuration: a forced nightly-style failure auto-files the issue (run → auto-created issue, label applied), and the suite stays green with reportlog enabled (run).
Prepared with Claude (AI) and submitted at my direction, per the invitation on #4273.
For reviewers
Two choices you may want differently: a dedicated
topic-hypothesislabel instead of reusingautomated issue(it would need creating before merge), and whether the flag should live in therun-hypothesishatch script rather thanPYTEST_ADDOPTSon the workflow step.Author attestation
TODO
changes/entry: n/a — CI-only change (same as fix: use hatch'sdefaultenv so the uv installer is inherited #4023)