Skip to content

Revert "chore: update pre-commit hooks" - #3877

Merged
maxrjones merged 2 commits into
mainfrom
revert-3876-pre-commit-ci-update-config
Apr 6, 2026
Merged

Revert "chore: update pre-commit hooks"#3877
maxrjones merged 2 commits into
mainfrom
revert-3876-pre-commit-ci-update-config

Conversation

@maxrjones

@maxrjones maxrjones commented Apr 6, 2026

Copy link
Copy Markdown
Member

Reverts #3876

#3876 caused the CI to fail, since it bumped the linters without applying fixes. I also think we should apply a policy to not bump dependencies that are <1 week old, given the number of recent supply chain attacks. I've opened #3878 to discuss that proposal.

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 6, 2026
@maxrjones
maxrjones requested a review from d-v-b April 6, 2026 20:30
@d-v-b

d-v-b commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

thanks for fixing this!

@maxrjones
maxrjones enabled auto-merge (squash) April 6, 2026 20:38
@maxrjones

Copy link
Copy Markdown
Member Author

thanks for fixing this!

no problem. I'm going to add the pre-commit/lint workflows to the required passing checks in the branch protection rules for main, so that auto-merge doesn't ignore it. It'll be easy to change back if you or others disagree.

@codecov

codecov Bot commented Apr 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.91%. Comparing base (4f23e8c) to head (975db79).
⚠️ Report is 118 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3877   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          86       86           
  Lines       10715    10715           
=======================================
  Hits         9956     9956           
  Misses        759      759           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maxrjones
maxrjones merged commit 57c82b4 into main Apr 6, 2026
29 checks passed
@maxrjones
maxrjones deleted the revert-3876-pre-commit-ci-update-config branch April 6, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants