This repository was archived by the owner on Feb 20, 2026. It is now read-only.
cosmetic changes - #6
Merged
Merged
Conversation
Replace ugly [ERROR] and [WARN ] prefixes by something nicer to read,
and remove [DEBUG] prefix.
This fixes using `tsrc` with the `--verbose` flag:
Old:
=> Updating manifest
[DEBUG]: /home/dmerej/tmp/tsrc/.tsrc/manifest $ git fetch --prune origin
[DEBUG]: /home/dmerej/tmp/tsrc/.tsrc/manifest $ git reset --hard @{u}
HEAD is now at e2f8457 add gitlab url
New:
=> Updating manifest
/home/dmerej/tmp/tsrc/.tsrc/manifest $ git fetch --prune origin
/home/dmerej/tmp/tsrc/.tsrc/manifest $ git reset --hard @{u}
Trivia:
This used to make sense back when ui.py was used as a logger
(a long time ago):
[DEBUG] this is a debug message
[INFO ] this is a info message
[WARN ] this is a warning message
[ERROR] this is an error message
Turned out we almost always something displayed to the screen between
ui.message() calls, so alignment does not matter much,
and the [INFO ] prefix was just noise.
So we removed the [INFO ] prefix from ui.info() but unintentionally left it in
ui.debug(), ui.warning(), and ui.error()
This change was already made in `tsrc` back in 35b4b6db5a05d2e1f3e09dc687dc4787905bf20c,
but somehow was lost when `ui.py` was extracted to its own project.
Sorry!
cgestes
approved these changes
Sep 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace ugly [ERROR] and [WARN ] prefixes by something nicer to read,
and remove [DEBUG] prefix.
This fixes using
tsrcwith the--verboseflag:Old:
=> Updating manifest
[DEBUG]: /home/dmerej/tmp/tsrc/.tsrc/manifest $ git fetch --prune origin
[DEBUG]: /home/dmerej/tmp/tsrc/.tsrc/manifest $ git reset --hard @{u}
HEAD is now at e2f8457 add gitlab url
New:
=> Updating manifest
/home/dmerej/tmp/tsrc/.tsrc/manifest $ git fetch --prune origin
/home/dmerej/tmp/tsrc/.tsrc/manifest $ git reset --hard @{u}
Trivia:
This used to make sense back when ui.py was used as a logger
(a long time ago):
Turned out we almost always something displayed to the screen between
ui.message() calls, so alignment does not matter much,
and the [INFO ] prefix was just noise.
So we removed the [INFO ] prefix from ui.info() but unintentionally left it in
ui.debug(), ui.warning(), and ui.error()
This change was already made in
tsrcback in your-tools/tsrc@35b4b6dbut somehow was lost when
ui.pywas extracted to its own project.Sorry!