Skip to content

Harden loading of upgrader #5791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 4 commits into from
May 31, 2023
Merged

Harden loading of upgrader #5791

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a53826b
Harden loading of upgrader
schlessera May 31, 2023
8d29e55
No error when upgrader skin does not exist (old WP Core)
schlessera May 31, 2023
b8308d8
No errors, just checking file existence upfront
schlessera May 31, 2023
79c0272
Fix bug in filepath
schlessera May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion php/utils-wp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,15 @@ function maybe_require( $since, $path ) {

function get_upgrader( $class, $insecure = false ) {
if ( ! class_exists( '\WP_Upgrader' ) ) {
require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
if ( file_exists( ABSPATH . 'wp-admin/includes/class-wp-upgrader.php' ) ) {
include ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
}
}

if ( ! class_exists( '\WP_Upgrader_Skin' ) ) {
if ( file_exists( ABSPATH . 'wp-admin/includes/class-wp-upgrader-skin.php' ) ) {
include ABSPATH . 'wp-admin/includes/class-wp-upgrader-skin.php';
}
}

$uses_insecure_flag = false;
Expand Down