Skip to content

Completions are broken#557

Merged
scribu merged 2 commits into
masterfrom
fix-completions
Jun 25, 2013
Merged

Completions are broken#557
scribu merged 2 commits into
masterfrom
fix-completions

Conversation

@scribu
Copy link
Copy Markdown
Member

@scribu scribu commented Jun 25, 2013

wp plugin in<TAB>Warning: unknown --completions parameter

Caused by #548.

The troubling thing is that the build passes.

@scribu
Copy link
Copy Markdown
Member Author

scribu commented Jun 25, 2013

With the current code, completions are rendered before WP is loaded:

  • pro: noticeably faster completions
  • pro: completions work even for early commands, like wp core download
  • con: completions don't work for commands defined in plugins anymore
    • they will work for community commands and for commands loaded via --require

scribu pushed a commit that referenced this pull request Jun 25, 2013
@scribu scribu merged commit 4ed971f into master Jun 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant