Skip to content

Allow user to suppress global parameters info from help display#5423

Merged
schlessera merged 2 commits into
masterfrom
feature/allow-suppressing-global-params
Sep 28, 2020
Merged

Allow user to suppress global parameters info from help display#5423
schlessera merged 2 commits into
masterfrom
feature/allow-suppressing-global-params

Conversation

@thrijith
Copy link
Copy Markdown
Member

@thrijith thrijith requested a review from a team as a code owner July 14, 2020 16:31
@thrijith
Copy link
Copy Markdown
Member Author

@schlessera
Copy link
Copy Markdown
Member

@thrijith It looks like there's an instance where the step syntax contains a double space, which is the likely cause of the failure.

Comment thread features/help.feature Outdated
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
@thrijith
Copy link
Copy Markdown
Member Author

@thrijith It looks like there's an instance where the step syntax contains a double space, which is the likely cause of the failure.

Yes, that's it 🙂

@thrijith
Copy link
Copy Markdown
Member Author

@schlessera there is one more in trunk https://travis-ci.org/github/wp-cli/wp-cli/jobs/708222192#L505-L511, but that seems to be the same as you mentioned on #cli

@schlessera
Copy link
Copy Markdown
Member

I'll see if I can fix that one today.

@schlessera
Copy link
Copy Markdown
Member

Created a Core trac bug report here: https://core.trac.wordpress.org/ticket/50670

@thrijith thrijith requested a review from schlessera July 31, 2020 21:17
@thrijith thrijith added this to the 2.5.0 milestone Jul 31, 2020
@schlessera schlessera merged commit 4246715 into master Sep 28, 2020
@schlessera schlessera deleted the feature/allow-suppressing-global-params branch September 28, 2020 07:20
@schlessera
Copy link
Copy Markdown
Member

I added a new issue for documenting this: #5444.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suppress global parameters

2 participants