Added an option to use reusable connections - #234
Closed
nnappe wants to merge 1 commit into
Closed
Conversation
…r is not changed. It creates a request.Session object at initialization time and uses it for future requests.
|
|
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 84.31% 81.48% -2.84%
==========================================
Files 24 24
Lines 1167 1172 +5
==========================================
- Hits 984 955 -29
- Misses 183 217 +34
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reuses HTTP connections so future REST calls skip the handshake. We've seen aprox 1s reductions in time to complete each requests (even from within IBM internal network). Might not be as much of a difference from within Bluemix.
The default behavior is not changed (unless objects are created with a use_connection_pool=True parameter). If so, a request.Session object is created at initialization time and used for future requests.