Chore: Refactor FilterArray code
#6152
Draft
+1,217
−743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging this PR will degrade performance by 29.88%Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | bench_sparse_coverage[0.5] |
365.3 µs | 329 µs | +11.03% |
| ⚡ | Simulation | bench_many_codes_few_values[2048] |
368.9 µs | 332.7 µs | +10.89% |
| ⚡ | Simulation | bench_many_codes_few_values[1024] |
366.3 µs | 330 µs | +11% |
| ⚡ | Simulation | bench_sparse_coverage[0.1] |
366.6 µs | 330.4 µs | +10.97% |
| ⚡ | Simulation | bench_many_codes_few_values[4096] |
375 µs | 338.7 µs | +10.7% |
| ❌ | Simulation | canonical_into_non_nullable[(10000, 1, 0.0)] |
25.9 µs | 36.3 µs | -28.74% |
| ❌ | Simulation | canonical_into_non_nullable[(10000, 10, 0.01)] |
222.8 µs | 306.2 µs | -27.23% |
| ❌ | Simulation | canonical_into_non_nullable[(10000, 1, 0.01)] |
32.4 µs | 41.2 µs | -21.38% |
| ❌ | Simulation | canonical_into_non_nullable[(10000, 10, 0.1)] |
382.3 µs | 471.8 µs | -18.96% |
| ❌ | Simulation | canonical_into_non_nullable[(10000, 1, 0.1)] |
48.2 µs | 57.2 µs | -15.62% |
| ❌ | Simulation | canonical_into_non_nullable[(10000, 10, 0.0)] |
195.7 µs | 279 µs | -29.88% |
| ⚡ | Simulation | canonical_into_nullable[(10000, 100, 0.0)] |
5 ms | 4.3 ms | +14.17% |
| ⚡ | Simulation | into_canonical_non_nullable[(10000, 1, 0.01)] |
47.1 µs | 39.2 µs | +20.13% |
| ⚡ | Simulation | into_canonical_non_nullable[(10000, 1, 0.0)] |
41.2 µs | 33.1 µs | +24.41% |
| ❌ | Simulation | into_canonical_non_nullable[(10000, 10, 0.0)] |
200.4 µs | 282.4 µs | -29.05% |
| ❌ | Simulation | into_canonical_non_nullable[(10000, 10, 0.01)] |
228.1 µs | 309.3 µs | -26.25% |
| ❌ | Simulation | into_canonical_non_nullable[(10000, 10, 0.1)] |
383.9 µs | 471.6 µs | -18.61% |
| ⚡ | Simulation | into_canonical_non_nullable[(10000, 1, 0.1)] |
63.7 µs | 55.3 µs | +15.07% |
| ⚡ | Simulation | into_canonical_nullable[(10000, 10, 0.0)] |
540.2 µs | 458.4 µs | +17.85% |
| ⚡ | Simulation | into_canonical_nullable[(10000, 100, 0.1)] |
6.9 ms | 6.1 ms | +13.53% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Footnotes
-
1323 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
52e8194 to
146bfad
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
8abe15d to
4527c0e
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
4527c0e to
dd46879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mostly cosmetic change to remove the old filter compute kernels from the
FilterArrayimplementation, placing the code invortex-array/src/arrays/filter/executeinstead of dispersed everywhere. The non-cosmetic changes are trivial, just making some things cleaner to understand.This is based on top of #6147, which is also based on top of #6146