Skip to content

pool: Add InvalidNode regexp to eject bad nodes - #93

Open
shazow wants to merge 1 commit into
masterfrom
pool-invalid-node
Open

pool: Add InvalidNode regexp to eject bad nodes#93
shazow wants to merge 1 commit into
masterfrom
pool-invalid-node

Conversation

@shazow

@shazow shazow commented Dec 6, 2019

Copy link
Copy Markdown
Member

Mark node as invalid if the client string matches a regular expression. Fixes #92

For example:

vipnode pool --invalid-node="Parity/v2.5.10"
  • Testing would be nice
  • Is there a better name for this flag?
  • Reject the node when it connects to the pool?

@shazow
shazow requested a review from ryanschneider December 6, 2019 15:14

@ryanschneider ryanschneider left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agent: Ability to disallow peers by user agent

2 participants