Skip to content

Fix pool metadata bugs - #48

Merged
shazow merged 10 commits into
masterfrom
pool-metadata
Jul 8, 2019
Merged

Fix pool metadata bugs#48
shazow merged 10 commits into
masterfrom
pool-metadata

Conversation

@shazow

@shazow shazow commented Jul 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Member
  • We weren't counting full nodes in the node set (because vipnode was originally designed to only track host->client relationships, not host-to-host). This changes to track all peers, regardless whether they're light clients or full nodes. In theory, the money bits should keep working because host-to-host debits will cancel out. There is some testing for this.
  • The store implementations weren't saving some metadata (block number), this adds a fix and some more scenarios to the store testsuite to cover it.
  • Adds integration test for more pool status metrics (block number, peers, balances)

@shazow
shazow requested a review from ryanschneider July 8, 2019 19:53
@shazow
shazow marked this pull request as ready for review July 8, 2019 19:53
ryanschneider
ryanschneider approved these changes Jul 8, 2019
View reviewed changes

@ryanschneider ryanschneider left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shazow
shazow merged commit 47c6081 into master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanschneider ryanschneider ryanschneider approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shazow @ryanschneider