Google cast support with docs#293
Conversation
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 48.04% 48.48% +0.44%
==========================================
Files 47 48 +1
Lines 1278 1291 +13
==========================================
+ Hits 614 626 +12
- Misses 664 665 +1
Continue to review full report at Codecov.
|
|
Thank you for submitting such a high-quality PR! However, at this moment I don't think it's a good idea to add a component in video-react just for Google Cast since it's not widely used. Video-react is highly customizable at many levels, so users can add the feature to support Google Cast by creating their own components. It will be nice if you can keep it a simple and clear doc page (like https://video-react.js.org/customize/customize-source/) demonstrating this use case. |
|
I respectfully disagree that Google Cast is not widely used. It's extremely popular and expected functionality. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 48.04% 48.48% +0.44%
==========================================
Files 47 48 +1
Lines 1278 1291 +13
==========================================
+ Hits 614 626 +12
- Misses 664 665 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
A very simple implementation of a cast sender application, for Chromecast and other receivers. The only working button in the control bar is the
PlayToggle. This can serve as a base for further implementation of the components required by projects.I made a
CastPlayTogglecomponent that wraps the regularPlayToggleso the easiest implementation is to disable the default controls and use this one instead. Another way is to let theCastPlayTogglehandle only the "remote player" and switching between controls in theControlBarcomponent instead, i.e.Let me know if anyone has thoughts about other approaches to the local/remote player controls and state display.