Skip to content

changed UAE weekends to SAT, SUN#609

Closed
lowcontext wants to merge 4 commits intovacanza:betafrom
lowcontext:master
Closed

changed UAE weekends to SAT, SUN#609
lowcontext wants to merge 4 commits intovacanza:betafrom
lowcontext:master

Conversation

@lowcontext
Copy link
Copy Markdown

Hi @dr-prodigy, UAE changed its weekend days to SAT and SUN starting on Jan 1st 2022. Updated the country file to reflect this. Let me know if any other change is needed. Thanks

dr-prodigy and others added 4 commits January 4, 2022 18:03
* Bump pre-commit/action from 2.0.0 to 2.0.3

Bumps [pre-commit/action](https://github.com/pre-commit/action) from 2.0.0 to 2.0.3.
- [Release notes](https://github.com/pre-commit/action/releases)
- [Commits](pre-commit/action@v2.0.0...v2.0.3)

---
updated-dependencies:
- dependency-name: pre-commit/action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Added missing states and two major holidays

- Updated borked calendarlab link and added new references for changes done
- Missing states and union territories added to list
- Sorted state list by status first and then alphabetically (UT's at the bottom)
- Full state names in comments along side state codes
- State code for Odisha changed to "OR" as used in govt websites
- Added Diwali and Holi from FBProphet as requested in vacanza#538 (only for India)
- Added warnings regarding year range for Diwali and Holi as in FBProphet

* Update corresponding tests

- Removed duplicate test for Gujarat
- Added new tests for Diwali and Holi

* v.0.11.4 beta

* Canada :: National Day for Truth and Reconciliation (vacanza#533)

earlier this year the government of Canada announced a new federal
holiday, National Day for Truth and Reconciliation. for 2021, two
provinces have adopted this day as an official holiday: Manitoba
and Nova Scotia. i'd expect by next year more to follow and will
update accordingly at that time.

* get full test coverage for canadian holidays (vacanza#536)

* add Juneteenth Observed holiday support (vacanza#537)

* Grammatical changes in docs (vacanza#549)

Spelling and grammar update. Excuse my OCD.

* CHANGES sync

* Add holidays for Kazakhstan (vacanza#534)

* Initial rough set of holidays for Kazakhstan
* Add tests for Kazakhstan holidays in 2020
* Adjust Kaz holidays to master and update tests
Co-authored-by: Hugh McNamara <hugh@intellisense.io>

* README+CHANGES sync

* flake8 compliance

* Add public holidays of Azerebaijan (vacanza#540)

Co-authored-by: Eldar Mustafayev <eldar-mustafayev@Eldars-MacBook-Air.local>

* CHANGES sync

* Warning review, CHANGES sync

* Spain fixes on PV (vacanza#555)

* CHANGES sync

* Add public holidays of Tunisia (vacanza#543)

* Add public holidays of Taiwan (vacanza#547)

* CHANGES + README.rst sync

* Fix India (Dussehra) vacanza#539

* Travis integration removal (vacanza#557)

* Italy fixes vacanza#546, CHANGES sync

* Italy fixes vacanza#546 - tests

* Patch/kor alt holidays (vacanza#535)

* remove unused statements
* add a comment for alternative holdays in Korea
* remove alternative holiday for New Year's Day, because it doesn't have it
* revise the comment for alternative holidays in Korea
* Korea alt holiday of Lunar New Year's Day should be next first non holiday after the holiday, not just +2
* remove first_lower util as its sole usage was gone
* edit Independence Movement Day because it also has alt holiday since 2021
* handle the case when two holidays are overlap (e.g. 2025/05/05)
* refactor Liberation Day
* fix Chuseok misnomer, refactor logic
* fix alt holiday for Hangul Day and add its testcase
* fix alt holiday for National Foundation Day and add its testcase
* quality assurance

* CHANGES sync

* Test coverage improvement

* Create Ethiopia.py

Adding Ethiopian holiday

* Update Ethiopia.py

* Update __init__.py

* Create test_ethiopia.py

* Update README.rst

* Update test_ethiopia.py

* More useful __repr__ and __str__ (vacanza#360)

* README change: more added test coverage requirements

* Date slices support fix vacanza#529, vacanza#530

* US Virginia Lee Jackson Day Removed After 2020 vacanza#559

* Update Ethiopia.py

Defining is_leap_year function

* test_coverage

Adding aditional test coverage

* Rename Ethiopia.py to ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Configs

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_egypt.py

* Update ci-cd.yml

* Update test_malaysia.py

* config

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update ethiopia.py

* Update ethiopia.py

* Update ethiopia.py

* Update test_ethiopia.py

* Create codeql-analysis.yml

* Delete codeql-analysis.yml

* Sphinx support - doc stub (vacanza#526)

* README.rst sync

* Add all test submodules automatically

* .gitattributes fix (vacanza#522)

* Update __init__.py

* Conflict resolution

* Update __init__.py

* Update colombia.py (vacanza#564) - redo

* Removed tests.py (obsolete)

* Czech (ie: misspelled Czechia) deprecated support removed

* UK standalone states deprecation vacanza#566

* UK standalone states deprecation vacanza#566

* Venezuela ISO code fix (vacanza#567)

* README.rst, CHANGES sync

* Support for North Macedonia (vacanza#570)

* README.rst, CHANGES sync

* UK standalone states deprecation vacanza#566 - better compatibility

* Update ethiopia.py

* Update ethiopia.py

* Support for Ethiopia (vacanza#558)

* CI/CD +python 3.10

* Update ethiopia.py

* Update test_ethiopia.py

More test coverages

* Revert "CI/CD +python 3.10"

This reverts commit c38dbaa.

* Updated venezuela.py

I added "Muerte del Libertador Simón Bolívar", which was missing, though, some people say its not a true holiday, but it is in my experience

* Updated venezuela.py

I added "Muerte del Libertador Simón Bolívar" test, which was missing, though, some people say its not a true holiday, but it is in my experience

* Update test_venezuela.py

Added a correction to pass the pull request test

* Update test_venezuela.py

Added a correction to pass the pull request test

* Add `NorthMacedonia` import to __init__ (vacanza#574)

Fix missing import for `NorthMacedonia` class/country.

* 'Polish' support drop

* 'Slovak' support drop

* UK states README fix

* Modified venezuela.py with pre-commit

* Defining ethiopian_isleap function

To properly calculate holidays between Sep 11 and Jan 1. Ethiopian isleap function should add 1 to current year.

* Venezuela fixes vacanza#576

* CHANGES sync

* UK fixes

* Moved country to class attribute (vacanza#573)

* CHANGES sync

* added observed support for Juneteenth Day

* Tests for observed Juneteenth Day

* copyright 2022, new version 0.12

* CD/CI tests - Pypi versions review

* removed pypy-3.6 tests for macOS compatibility

* even safer pypy tests for macOS compatibility

* Add Observed support for Juneteenth Day (vacanza#578)

* v.0.12

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Canute <46291012+canute24@users.noreply.github.com>
Co-authored-by: Chris Turra <cturra@gmail.com>
Co-authored-by: Kelsey Karin Hawley <karin@karinscoils.com>
Co-authored-by: Hugh McNamara <chiuczek@users.noreply.github.com>
Co-authored-by: Eldar Mustafayev <33187926+eldar-mustafayev@users.noreply.github.com>
Co-authored-by: Eldar Mustafayev <eldar-mustafayev@Eldars-MacBook-Air.local>
Co-authored-by: Artem Tserekh <kvertea@gmail.com>
Co-authored-by: Ihebski <ihebski@users.noreply.github.com>
Co-authored-by: Further <55025025+ifurther@users.noreply.github.com>
Co-authored-by: Mike Borsetti <26698111+mborsetti@users.noreply.github.com>
Co-authored-by: mmontel-wgs <mmontel@webgeoservices.com>
Co-authored-by: jdh <dongho971220@gmail.com>
Co-authored-by: Tewodros Meshesha <tewodroskbd65@gmail.com>
Co-authored-by: antusystem <57923391+antusystem@users.noreply.github.com>
Co-authored-by: javicalle <31999997+javicalle@users.noreply.github.com>
Co-authored-by: Alejandro Antunes <aantunes@netnovation.com>
Co-authored-by: amelkiy <amelkiy@gmail.com>
Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.4.2 to 1.5.0.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.4.2...v1.5.0)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1754897390

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.945%

Totals Coverage Status
Change from base Build 1709373466: 0.0%
Covered Lines: 5781
Relevant Lines: 5846

💛 - Coveralls

@dr-prodigy dr-prodigy changed the base branch from master to beta January 29, 2022 11:08
@dr-prodigy
Copy link
Copy Markdown
Collaborator

Hi @marcomasulli thank you for your work.
Unfortunately, it is not mergeable (all changes/fixes should start from beta branch, and therefore there are conflicts).
Also, UAE has just been reviewed by @mborsetti with #586 and #606.
Long story short, I'll be applying your changes again on the current code: soon available on beta branch.
Thx again, best

@lowcontext
Copy link
Copy Markdown
Author

lowcontext commented Jan 29, 2022 via email

@mborsetti
Copy link
Copy Markdown
Contributor

@dr-prodigy The code in this PR isn't going to work because it would apply the new definition retroactively. Look at the newly-merged saudi_arabia.py; there we now define WEEKEND within _populate() so we can change its value based on the year being populated.

@dr-prodigy
Copy link
Copy Markdown
Collaborator

@mborsetti you are right!
In my implementation in fact I don't apply the original code (which was in fact wrong for the reason you say), but instead I added the new weekend logic to _populate() as you correctly suggest.
Thank you for pointing this out! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants