hwclock: use RTC_PARAM_GET and RTC_VL_READ for ifdefs - #4532
Merged
Conversation
Replace broad #ifndef __GNU__ guards with feature-specific #ifdef RTC_PARAM_GET and #ifdef RTC_VL_READ to guard the code that depends on these ioctls. Move the fallback definitions for RTC_PARAM_GET, RTC_PARAM_SET, RTC_VL_READ, and RTC_VL_CLR from hwclock-rtc.c to hwclock.h under feature macros consistently. Signed-off-by: Karel Zak <kzak@redhat.com>
karelzak
force-pushed
the
PR/hwclock-rtc-ifdefs
branch
from
August 6, 2026 16:23
b0d9d9a to
f089382
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace broad
#ifndef __GNU__guards with feature-specific#ifdef RTC_PARAM_GETand#ifdef RTC_VL_READto guard the code that dependson these ioctls.
Move the fallback definitions for
RTC_PARAM_GET,RTC_PARAM_SET,RTC_VL_READ, andRTC_VL_CLRfrom hwclock-rtc.c to hwclock.h under#ifdef __linux__, so both hwclock.c and hwclock-rtc.c can use thefeature macros consistently.
This also makes it straightforward for PR #4513 to add new RTC
parameters — the new
RTC_PARAM_BATTERY_LOW_DETECTdefine andhwclock_params[]entry will naturally sit inside the existing#ifdef RTC_PARAM_GETguards.