Infer dependencies from `setup.cfg` by Copilot · Pull Request #1795 · usethis-python/usethis-python

Copilot · 2026-04-04T00:20:01Z

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/51322711-9cdb-484c-8a37-2aa0ad08ac75 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

codspeed-hq · 2026-04-04T02:25:03Z

Merging this PR will not alter performance

✅ 2 untouched benchmarks

_{Comparing copilot/infer-dependencies-setup-cfg (841f512) with main (7c45f33)}

nathanjmcdougall · 2026-04-04T02:26:01Z

@copilot some of the tests are failing. See the GH Actions config for details. Please fix the issue, and then create a ticket regarding what went wrong in terms of the agent inferring which tests were relevant to run.

…rementsTxt Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/f7cfd326-fb26-42fa-af09-f0b5d180b7dd Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot · 2026-04-04T02:31:51Z

@copilot some of the tests are failing. See the GH Actions config for details. Please fix the issue, and then create a ticket regarding what went wrong in terms of the agent inferring which tests were...

Fixed in 62e9919. The 5 failing TestWriteSimpleRequirementsTxt tests in test_init.py needed SetupCFGManager() added to their context, since write_simple_requirements_txt() calls get_project_deps() which now reads from setup.cfg.

The root cause was that when I searched for tests to update, I only looked for direct callers of get_project_deps() and get_dep_groups(), missing test_init.py which calls write_simple_requirements_txt() — an indirect/transitive caller in _init.py. I've filed issue #1808 to track this lesson about checking transitive callers when modifying _deps.py.

nathanjmcdougall · 2026-04-04T06:51:35Z

@copilot some of the tests are still failing. See the GH Actions logs for details. Please fix the issue, and then create a ticket regarding what went wrong in terms of the agent inferring which tests were relevant to run.

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/98169524-606e-47a4-9c6b-b498a66104d0 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot · 2026-04-04T07:03:49Z

@copilot some of the tests are still failing. See the GH Actions logs for details. Please fix the issue, and then create a ticket regarding what went wrong in terms of the agent inferring which tests ...

Fixed in 32abab5. The root cause was stale usethis_config.inferred_backend leaking between tests.

Tests in my new TestGetDepGroups::TestPoetry class (and the pre-existing TestGetProjectDeps::TestPoetry) set usethis_config.backend = BackendEnum.poetry via direct assignment rather than the usethis_config.set() context manager. Direct assignment leaves inferred_backend cached as poetry after the test completes. Since get_backend() checks inferred_backend first, all subsequent tests that relied on backend auto-detection silently received poetry and called the Poetry subprocess (which is broken in the min-dependencies CI environment).

Fix: added usethis_config.backend = BackendEnum(BACKEND_DEFAULT) and usethis_config.inferred_backend = None resets to the autouse clear_functools_caches fixture in tests/conftest.py. Filed issue #1812 to track this lesson.

nathanjmcdougall · 2026-04-04T17:24:16Z

@copilot some of the tests are still failing. See the GH Actions logs for details. Please fix the issue, and then create a ticket regarding what went wrong in terms of the agent inferring which tests were relevant to run.

…upCFGManager to missing test contexts Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/9ec216b2-e65e-4fec-aa2f-6addd5a627e1 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot · 2026-04-04T18:11:48Z

@copilot some of the tests are still failing. See the GH Actions logs for details. Please fix the issue, and then create a ticket regarding what went wrong in terms of the agent inferring which tests ...

Fixed in bfb2905. There were two root causes:

1. UnexpectedSetupCFGIOError in tests missing SetupCFGManager() context — test_base.py::TestIsUsed, test_core_tool.py::TestDeptry::TestAdd, TestRequirementsTxt, TestPyprojectFmt, etc. all used PyprojectTOMLManager() without SetupCFGManager(). Added SetupCFGManager() to ~30 test contexts.

2. Missing try-finally in UsethisConfig.set() (root cause of the cascading "empty output" failures): Python's @contextmanager does NOT run cleanup code after yield if an exception is raised inside the with block — unless try-finally is used. Since UsethisConfig.set() lacked try-finally, any UnexpectedSetupCFGIOError raised inside a with usethis_config.set(quiet=True): block (in _core/tool.py) left quiet=True permanently, causing ~80 subsequent tests to produce empty output.

Fixed _config.py to wrap yield in try-finally, and filed issue #1818 to track this lesson about @contextmanager requiring try-finally for proper cleanup on exceptions.

codecov · 2026-04-04T18:35:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

nathanjmcdougall · 2026-04-06T03:44:17Z

+    result: dict[str, list[Dependency]] = {}
+    for extra_name in cfg["options.extras_require"].options():  # type: ignore[union-attr]
+        raw_value: str | None = cfg["options.extras_require"][extra_name].value  # type: ignore[union-attr]
+        if raw_value is None:  # pragma: no cover


@copilot please remove all pragma comments. Also all "type:" comments should be converted to "pyright:".

We should create a GitHub ticket for this lesson so that we make a hook which forbids particular keywords in comments, provided via CLI. This is one of them: "pragma". Another is "type:"

Done in 841f512. Removed all # pragma: no cover comments and # type: ignore[union-attr] comments from setup_cfg/deps.py. Since Option.value returns str | None but is always a non-None string when parsed from a file (empty values return ''), I simplified the code to use raw_value or "" instead of the unreachable None checks. Pyright requires no type suppression for this code.

Filed issue #1820 to track adding a prek hook that forbids pragma: and type: ignore keywords in comments.

…_cfg/deps.py Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/dddc5605-30c3-4d38-9d88-5e6b7fc9b894 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

nathanjmcdougall · 2026-04-06T18:44:19Z

+def get_setup_cfg_dep_groups() -> dict[str, list[Dependency]]:
+    """Get dependency groups from setup.cfg [options.extras_require].
+
+    This reads the ``[options.extras_require]`` section of ``setup.cfg``, which is the


@copilot please remove double backticks in docstrings.

Please also create a lesson about this - with the suggested solution that we create a prek hook to forbid double backticks in docstrings, and update agent skills accordingly.

Done in 77e7b4e. Replaced all double backticks with single backticks in setup_cfg/deps.py and _deps.py docstrings. Filed issue #1822 to track adding a prek hook to forbid double backticks in docstrings.

nathanjmcdougall · 2026-04-06T18:47:13Z

    Usually this is just the dependencies in the ``project.dependencies`` section
    of the ``pyproject.toml`` file. When the poetry backend is active, also
-    reads from ``[tool.poetry.dependencies]``.
+    reads from ``[tool.poetry.dependencies]``. Also merges from ``setup.cfg``


@copilot again - remove double backticks.

Fixed in 77e7b4e.

nathanjmcdougall · 2026-04-06T18:47:21Z


    Reads from ``[dependency-groups]`` (PEP 735). When the poetry backend
-    is active, also reads from ``[tool.poetry.group.*.dependencies]``.
+    is active, also reads from ``[tool.poetry.group.*.dependencies]``. Also


Again -remove double backticks

Fixed in 77e7b4e.

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/df0af713-7fa1-4f9f-82e6-b8cd5da229d6 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

nathanjmcdougall · 2026-04-06T19:05:28Z

Per #1823 I want to close this PR for now until some bigger questions are resolved.

Initial plan

ad0a947

Copilot AI assigned Copilot and nathanjmcdougall Apr 4, 2026

Copilot started work on behalf of nathanjmcdougall April 4, 2026 00:20 View session

Copilot AI linked an issue Apr 4, 2026 that may be closed by this pull request

Infer dependencies from setup.cfg #895

Open

Copilot AI and others added 2 commits April 4, 2026 00:32

Add setup.cfg dependency inference support

a2f99c3

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/51322711-9cdb-484c-8a37-2aa0ad08ac75 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Fix type annotations and clarify docstrings in setup.cfg dep inference

10be3a5

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/51322711-9cdb-484c-8a37-2aa0ad08ac75 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add support for dependencies in setup.cfg~~ Infer dependencies from setup.cfg Apr 4, 2026

Copilot finished work on behalf of nathanjmcdougall April 4, 2026 00:38

Copilot AI requested a review from nathanjmcdougall April 4, 2026 00:38

nathanjmcdougall approved these changes Apr 4, 2026

View reviewed changes

nathanjmcdougall marked this pull request as ready for review April 4, 2026 02:20

Copilot AI had a problem deploying to codecov April 4, 2026 02:20 Failure

Copilot started work on behalf of nathanjmcdougall April 4, 2026 02:26 View session

Fix test_init.py: add SetupCFGManager context to TestWriteSimpleRequi…

62e9919

…rementsTxt Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/f7cfd326-fb26-42fa-af09-f0b5d180b7dd Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot AI requested a review from nathanjmcdougall April 4, 2026 02:32

Copilot finished work on behalf of nathanjmcdougall April 4, 2026 02:32

Copilot AI had a problem deploying to codecov April 4, 2026 05:09 Failure

Copilot started work on behalf of nathanjmcdougall April 4, 2026 06:51 View session

Fix test isolation: reset backend/inferred_backend in autouse fixture

32abab5

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/98169524-606e-47a4-9c6b-b498a66104d0 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

nathanjmcdougall mentioned this pull request Apr 4, 2026

agent: tests that set usethis_config attributes directly must use context manager or rely on conftest reset #1812

Closed

Copilot finished work on behalf of nathanjmcdougall April 4, 2026 07:04

Copilot AI had a problem deploying to codecov April 4, 2026 08:46 Failure

Merge branch 'main' into copilot/infer-dependencies-setup-cfg

5a62eaa

nathanjmcdougall had a problem deploying to codecov April 4, 2026 17:07 — with GitHub Actions Failure

Copilot started work on behalf of nathanjmcdougall April 4, 2026 17:24 View session

nathanjmcdougall mentioned this pull request Apr 4, 2026

agent: contextlib.contextmanager does NOT restore state on exception unless try-finally is used #1818

Closed

Copilot finished work on behalf of nathanjmcdougall April 4, 2026 18:12

Copilot AI temporarily deployed to codecov April 4, 2026 18:32 Inactive

nathanjmcdougall reviewed Apr 6, 2026

View reviewed changes

Copilot started work on behalf of nathanjmcdougall April 6, 2026 03:46 View session

Remove pragma: no cover comments and type: ignore comments from setup…

841f512

…_cfg/deps.py Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/dddc5605-30c3-4d38-9d88-5e6b7fc9b894 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

nathanjmcdougall mentioned this pull request Apr 6, 2026

Add prek hook to forbid banned comment keywords (pragma, type:) #1820

Closed

Copilot AI requested a review from nathanjmcdougall April 6, 2026 03:53

Copilot finished work on behalf of nathanjmcdougall April 6, 2026 03:53

Copilot AI temporarily deployed to codecov April 6, 2026 18:34 Inactive

nathanjmcdougall requested changes Apr 6, 2026

View reviewed changes

Copilot started work on behalf of nathanjmcdougall April 6, 2026 18:49 View session

nathanjmcdougall mentioned this pull request Apr 6, 2026

Add prek hook to forbid double backticks in docstrings #1822

Closed

Replace double backticks with single backticks in docstrings

77e7b4e

Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/df0af713-7fa1-4f9f-82e6-b8cd5da229d6 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>

Copilot finished work on behalf of nathanjmcdougall April 6, 2026 18:55

Copilot AI requested a review from nathanjmcdougall April 6, 2026 18:55

nathanjmcdougall marked this pull request as draft April 6, 2026 18:58

nathanjmcdougall mentioned this pull request Apr 6, 2026

Ensure we are consistently handling optional dev groups vs. extras #1823

Open

nathanjmcdougall closed this Apr 6, 2026

Conversation

Copilot AI commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

nathanjmcdougall commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026

Uh oh!

nathanjmcdougall commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026

Uh oh!

nathanjmcdougall commented Apr 4, 2026

Uh oh!

Copilot AI commented Apr 4, 2026

Uh oh!

codecov bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nathanjmcdougall Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

nathanjmcdougall Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

nathanjmcdougall Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

nathanjmcdougall Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

nathanjmcdougall commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Apr 4, 2026 •

edited

Loading

codspeed-hq bot commented Apr 4, 2026 •

edited

Loading

codecov bot commented Apr 4, 2026 •

edited

Loading