Skip to content

Fix status_arg help text copy-paste bug and add uniqueness test#1784

Merged
nathanjmcdougall merged 4 commits intomainfrom
copilot/write-test-typer-options-help-text
Apr 3, 2026
Merged

Fix status_arg help text copy-paste bug and add uniqueness test#1784
nathanjmcdougall merged 4 commits intomainfrom
copilot/write-test-typer-options-help-text

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026 •
edited
Loading

status_arg in options.py had help text "Docstring style to enforce." copied from docstyle_style_arg. Added a test to prevent future duplicates.

  • Bug fix: Changed status_arg help text to "Development status to set."
  • Regression test: TestUniqueHelpText iterates all typer.Option/typer.Argument objects in options.py and asserts no two share the same help string
# Would have caught the original bug:
# status_arg  = typer.Argument(default=..., help="Docstring style to enforce.")  # ← duplicate
# docstyle_style_arg = typer.Argument(default="google", help="Docstring style to enforce.")

Copilot AI linked an issue Apr 3, 2026 that may be closed by this pull request
Write a test that all typer options objects have different help text #1779
Closed
Copilot AI and others added 2 commits April 3, 2026 20:37
Copilot AI changed the title [WIP] Add test to verify distinct help text for typer options Fix status_arg help text copy-paste bug and add uniqueness test Apr 3, 2026
Copilot AI requested a review from nathanjmcdougall April 3, 2026 20:41
@nathanjmcdougall nathanjmcdougall marked this pull request as ready for review April 3, 2026 20:49
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 3, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 2 untouched benchmarks

Comparing copilot/write-test-typer-options-help-text (0a3c600) with main (d6c172a)

Open in CodSpeed

@nathanjmcdougall nathanjmcdougall merged commit 902799e into main Apr 3, 2026
20 checks passed
@nathanjmcdougall nathanjmcdougall deleted the copilot/write-test-typer-options-help-text branch April 3, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nathanjmcdougall nathanjmcdougall nathanjmcdougall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nathanjmcdougall nathanjmcdougall

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Write a test that all typer options objects have different help text

2 participants

@nathanjmcdougall