Rename _HOOK_ORDER to HOOK_GROUPS as list of lists#1749
Merged
nathanjmcdougall merged 2 commits intomainfrom Apr 1, 2026
Merged
Rename _HOOK_ORDER to HOOK_GROUPS as list of lists#1749nathanjmcdougall merged 2 commits intomainfrom
_HOOK_ORDER to HOOK_GROUPS as list of lists#1749nathanjmcdougall merged 2 commits intomainfrom
Conversation
…f lists Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/cfa13f2e-4c66-40aa-beda-bac181bc2603 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update _HOOK_ORDER to be more sophisticated with groups
Rename Apr 1, 2026
_HOOK_ORDER to HOOK_GROUPS as list of lists
nathanjmcdougall
approved these changes
Apr 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_HOOK_ORDERwas a flat list of hook names with no way to express which hooks can safely run in parallel (relevant for prek priority groups). Replace it with aHOOK_GROUPS: list[list[str]]where each inner list is a group of hooks at the same priority level.Structure
Flattening produces the same ordering as the original
_HOOK_ORDER.Changes
hooks.py: Replace_HOOK_ORDERwithHOOK_GROUPS, flatten inline inadd_repo()for index-based orderingtest_core_tool.py: Update import and flatten before membership checktest_hooks.py: AddTestHookGroups(structure validation, no duplicates, non-empty), update comments