Return exit code 1 from export hooks when files are modified#1725
Merged
nathanjmcdougall merged 3 commits intomainfrom Apr 1, 2026
Merged
Return exit code 1 from export hooks when files are modified#1725nathanjmcdougall merged 3 commits intomainfrom
nathanjmcdougall merged 3 commits intomainfrom
Conversation
Modify export-functions.py, export-module-tree.py, and export-skills-directory.py to compare new content with existing file content and return exit code 1 when the file is actually changed. This follows the pre-commit convention that hooks modifying files should signal the change via a non-zero exit code. Also update the usethis-prek-hook-bespoke-create skill to document this principle. Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/76cfba7e-2df3-47e6-92d3-248a8eb6332a Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update hooks to return exit code 1 as required
Return exit code 1 from export hooks when files are modified
Apr 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nathanjmcdougall
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-commit convention: hooks that modify files must return exit code 1 so pre-commit knows to re-stage and re-run. Our three export hooks (
export-functions,export-module-tree,export-skills-directory) always returned 0 after writing.export-skills-directory.py: Extract_collect_skills()helper to stay within ruff's PLR0912 branch limit after adding the comparison logic.usethis-prek-hook-bespoke-createskill to document this exit code convention for future hook authors.Core pattern applied to each hook: