Document files_manager deferred-write semantics and subprocess implications#1720
Merged
nathanjmcdougall merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
…idance - Expanded files_manager() docstring to explain locking, deferred reads, atomic writes on exit, and subprocess implications - Expanded FileManager class docstring with a lifecycle description and subprocess guidance - Added "Using files_manager in tests" section to usethis-python-test skill with concrete examples of correct/incorrect patterns Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/3a6cfc9a-bb96-4d0f-bfab-5f9fb43ef279 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add agent config and documentation for files manager
Document Apr 1, 2026
files_manager deferred-write semantics and subprocess implications
nathanjmcdougall
approved these changes
Apr 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nathanjmcdougall
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents misdiagnosed test failures (#1652) because they didn't understand that
files_managerdefers all writes until context exit — subprocesses can't see uncommitted in-memory changes.files_manager()docstring (_config_file.py): Explains locking on entry, lazy reads, atomic flush on exit, and the subprocess visibility constraint.FileManagerclass docstring (_file/manager.py): Adds a numbered lifecycle (Enter → Read → Commit → Exit) with explicit subprocess guidance.usethis-python-testskill (SKILL.mdv1.1): New "Usingfiles_managerin tests" section with correct/incorrect patterns and a decision rule.Key pattern the skill now teaches: