Add check-banned-words hook to enforce generic hook scripts#1687
Merged
nathanjmcdougall merged 5 commits intomainfrom Apr 1, 2026
Merged
Add check-banned-words hook to enforce generic hook scripts#1687nathanjmcdougall merged 5 commits intomainfrom
nathanjmcdougall merged 5 commits intomainfrom
Conversation
Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/4baf8ec2-fc9b-4f0a-8a32-0a73e5402d96 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/4baf8ec2-fc9b-4f0a-8a32-0a73e5402d96 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add a hook to ban a list of words from hooks directory
Add check-banned-words hook to enforce generic hook scripts
Apr 1, 2026
nathanjmcdougall
approved these changes
Apr 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hooks in
hooks/should be project-agnostic and not reference the package name. This adds a hook to enforce that invariant and fixes existing violations.New hook:
hooks/check-banned-words.py.pyfiles in the hooks directory for banned words (passed as positional CLI args)\bword-boundary matching to avoid false positivesExisting hooks generalized
check-skills-documented.py/export-skills-directory.py:--prefixchanged fromdefault="usethis-"torequired=Truecheck-test-skeleton.py: help text example changed from'tests/usethis'to'tests/mypackage'Pre-commit config
check-banned-wordswithargs: ["--hooks-dir=hooks", "usethis"]--prefix=usethis-toexport-skills-directoryargs (previously relied on the now-removed default)