Generalize check-test-skeleton hook with --source-dir and --tests-dir CLI args#1679
Merged
nathanjmcdougall merged 2 commits intomainfrom Apr 1, 2026
Merged
Conversation
… CLI args Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/2b280478-56ce-4e9a-a779-287bc273cace Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Generalize check-test-skeleton hook with CLI args
Generalize Apr 1, 2026
check-test-skeleton hook with --source-dir and --tests-dir CLI args
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nathanjmcdougall
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
check-test-skeletonhook hard-codedSRC_DIRandTESTS_DIRas constants, preventing reuse in other projects.hooks/check-test-skeleton.py: Replace constants with required--source-dirand--tests-dirargparsearguments. Path mapping usestests_dir.parentdynamically instead of hard-coded"tests"..pre-commit-config.yaml: Pass args explicitly to the hook entry: