Skip to content

Add type annotations and handle an edge case for hook IDs which are N…#1667

Merged
nathanjmcdougall merged 1 commit intomainfrom
refactor/handle-edge-case-hook-id-non-type-annotations
Mar 31, 2026
Merged

Add type annotations and handle an edge case for hook IDs which are N…#1667
nathanjmcdougall merged 1 commit intomainfrom
refactor/handle-edge-case-hook-id-non-type-annotations

Conversation

@nathanjmcdougall
Copy link
Copy Markdown
Collaborator

…one in pre-commit integration

Working towards enabling reportUnknownMemberType in basedpyright

…one in pre-commit integration

Working towards enabling `reportUnknownMemberType` in basedpyright
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 31, 2026

Merging this PR will not alter performance

✅ 2 untouched benchmarks


Comparing refactor/handle-edge-case-hook-id-non-type-annotations (929b758) with main (b438c90)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (c3d3007) during the generation of this report, so b438c90 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@nathanjmcdougall nathanjmcdougall merged commit ae394f8 into main Mar 31, 2026
20 checks passed
@nathanjmcdougall nathanjmcdougall deleted the refactor/handle-edge-case-hook-id-non-type-annotations branch March 31, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant