Enable reportUnnecessaryComparison in basedpyright#1399
Merged
nathanjmcdougall merged 2 commits intomainfrom Mar 13, 2026
Merged
Enable reportUnnecessaryComparison in basedpyright#1399nathanjmcdougall merged 2 commits intomainfrom
reportUnnecessaryComparison in basedpyright#1399nathanjmcdougall merged 2 commits intomainfrom
Conversation
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add enable reportUnnecessaryComparison in basedpyright
Enable Mar 13, 2026
reportUnnecessaryComparison in basedpyright
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the
reportUnnecessaryComparisonbasedpyright rule and removes the dead code/redundant conditions it surfaces.Changes
pyproject.toml: RemovereportUnnecessaryComparison = falseoverride._core/readme.py:get_project_name()returnsstr, neverNone— simplify the content-building branches, removing two deadelif/elsearms.bitbucket/pipeweld.py:ParallelItem.parallelis typed as non-optionalParallel— remove fourif item.parallel is not None:guards and dedent the inner logic.bitbucket/steps.py:StepItem.step: StepandStep1.step: Step2are non-optional — remove two redundantif ... is not Nonefilters from list comprehensions.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://mirrors.aliyun.com/pypi/packages/70/1b/4273d02565a4e86f238e9fee23e6c5c3bb7b5c237c63228e1b72451db224/uv-0.9.15-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl/home/REDACTED/work/usethis-python/usethis-python/.venv/bin/prek prek run -a ps(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
reportUnnecessaryComparisonin basedpyright #1334📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.