Skip to content

Send user agent for docker update checks - #2724

Open
Mainfrezzer wants to merge 1 commit into
unraid:masterfrom
Mainfrezzer:Mainfrezzer-patch-3
Open

Send user agent for docker update checks#2724
Mainfrezzer wants to merge 1 commit into
unraid:masterfrom
Mainfrezzer:Mainfrezzer-patch-3

Conversation

@Mainfrezzer

@Mainfrezzer Mainfrezzer commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The docker curl update check doesnt send any user agent and that can end up being blocked (as a lot of botted traffic is user agent less). Docker/dynamix curl actions should clearly identify themselves as such.

Summary by CodeRabbit

  • Bug Fixes
    • Added a Docker/Unraid client identifier to requests, including HEAD requests, improving compatibility with connected services.

@github-actions

Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.08.14.2239
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2724/webgui-pr-2724.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix.docker.manager/include/Helpers.php

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2724, or run:

plugin remove webgui-pr-2724

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 513e56aa-e4c7-44df-a2b8-7f6455ff2a77

📥 Commits

Reviewing files that changed from the base of the PR and between 4b3c59e and ef7b3c5.

📒 Files selected for processing (1)
  • emhttp/plugins/dynamix.docker.manager/include/Helpers.php

Walkthrough

The cURL helper now sets the Docker/Unraid client user agent for general requests and explicitly preserves the setting for HEAD requests.

Changes

Docker client identification

Layer / File(s) Summary
cURL user agent configuration
emhttp/plugins/dynamix.docker.manager/include/Helpers.php
getCurlHandle sets the Docker/Unraid client user agent for general and HEAD requests.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ef7b3

This is a small localized change to identify Docker update-check requests, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: elibosley

Poem

A rabbit checked the curl with care,
And placed a client name there.
HEAD requests too,
Keep the label true,
So Docker hops with proper flair.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: sending a user agent for Docker update checks.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant