Skip to content
This repository was archived by the owner on Jul 31, 2025. It is now read-only.

chore: cleanup code from Unraid 6 - #39

Merged
Derek Kaser (dkaser) merged 1 commit into
mainfrom
cleanup6
May 6, 2025
Merged

chore: cleanup code from Unraid 6#39
Derek Kaser (dkaser) merged 1 commit into
mainfrom
cleanup6

Conversation

@dkaser

@dkaser Derek Kaser (dkaser) commented May 6, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Refactor
    • Removed automatic patching of SSH and nginx startup scripts during the Tailscale plugin startup process. No changes to other Tailscale configuration or startup behaviors.

@coderabbitai

coderabbitai Bot commented May 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Walkthrough

Two static methods, patchSSH and patchNginx, were removed from the System class, along with their logic for patching SSH and nginx startup scripts. Corresponding calls to these methods were also removed from the pre-startup script. All other startup tasks and service control flows remain unchanged.

Changes

File(s) Change Summary
src/usr/local/emhttp/plugins/tailscale/include/Tailscale/System.php Removed static methods patchSSH and patchNginx along with all related logic and operations.
src/usr/local/emhttp/plugins/tailscale/pre-startup.php Removed calls to Utils::run_task for Tailscale\System::patchNginx and Tailscale\System::patchSSH. Other startup logic unchanged.

Poem

A rabbit hopped through scripts today,
Snipping patches clean away.
No more tweaks for SSH or nginx in sight,
The code feels lighter, airy, and bright.
With a whisk of paws, the tasks are trimmed—
Onward to new features, joyfully brimmed!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2aa553f and e8c0e07.

📒 Files selected for processing (2)
  • src/usr/local/emhttp/plugins/tailscale/include/Tailscale/System.php (0 hunks)
  • src/usr/local/emhttp/plugins/tailscale/pre-startup.php (0 hunks)
💤 Files with no reviewable changes (2)
  • src/usr/local/emhttp/plugins/tailscale/pre-startup.php
  • src/usr/local/emhttp/plugins/tailscale/include/Tailscale/System.php
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dkaser
Derek Kaser (dkaser) merged commit e52ee66 into main May 6, 2025
@dkaser
Derek Kaser (dkaser) deleted the cleanup6 branch May 6, 2025 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dkaser