Skip to content

fix: old references in erase script - #109

Merged
Derek Kaser (dkaser) merged 1 commit into
trunkfrom
fix/erase-script
Jul 1, 2026
Merged

fix: old references in erase script#109
Derek Kaser (dkaser) merged 1 commit into
trunkfrom
fix/erase-script

Conversation

@dkaser

@dkaser Derek Kaser (dkaser) commented Jul 1, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Improved the Tailscale erase/reset flow so the service restarts more reliably after clearing configuration.
    • Made the post-erase wait behavior more consistent, helping settings updates complete more predictably.

@dkaser
fix: old references in erase script
9bdb0fb 
Signed-off-by: Derek Kaser <11674153+dkaser@users.noreply.github.com>
@github-actions github-actions Bot added the fix label Jul 1, 2026
@dkaser
Derek Kaser (dkaser) merged commit cefa439 into trunk Jul 1, 2026
4 of 5 checks passed
@dkaser
Derek Kaser (dkaser) deleted the fix/erase-script branch July 1, 2026 01:24
@coderabbitai

coderabbitai Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2a9dfe2b-0426-432a-8659-9217991a1ef4

📥 Commits

Reviewing files that changed from the base of the PR and between a2dac6a and 9bdb0fb.

📒 Files selected for processing (1)
  • src/usr/local/emhttp/plugins/tailscale/erase.sh

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📝 Walkthrough

Walkthrough

The erase.sh script for the Tailscale plugin now sources its logging helper from a shared utilities path instead of the local plugin directory. It also replaces a previously scheduled at job (delayed restart via update-settings.sh) with a direct call to start rc.tailscale, followed by a 10-second sleep.

Changes

Erase Script Restart Behavior

Layer / File(s) Summary
Log source and Tailscale restart update
src/usr/local/emhttp/plugins/tailscale/erase.sh		 Logging helper is now sourced from /usr/local/php/unraid-tailscale-utils/log.sh; Tailscale restart replaces the scheduled at job with a direct /etc/rc.d/rc.tailscale start call followed by sleep 10.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/erase-script

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dkaser