[PENDING] refactor(graphrunner): route metrics through observability/metrics#198
Open
xytan0056 wants to merge 1 commit into
Open
[PENDING] refactor(graphrunner): route metrics through observability/metrics#198xytan0056 wants to merge 1 commit into
xytan0056 wants to merge 1 commit into
Conversation
This was referenced Jul 14, 2026
The graphrunner reads the request emitter from ctx via metrics.FromContext instead of taking a tally.Scope at construction. The substep timers (bazel_query_duration, git_file_hashes_duration, target_hash_duration) and the target-count gauge move to the shared metric-name constants under the graph_runner op sub-scope. target_count becomes targets_count but stays a gauge to preserve the time-series shape. The orchestrator stops threading its scope into the runner; it still uses that scope for its own (not-yet-migrated) metrics until the next commit.
489af72 to
a48bdee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes the native graphrunner's metrics through
observability/metrics.ctxviametrics.FromContext(the orchestrator forwards the same ctx the controller seeds), so it no longer takes atally.Scopeat construction.bazel_query_duration,git_file_hashes_duration,target_hash_duration) and the target-count gauge move to shared metric-name constants under thegraph_runnerop sub-scope.target_count→targets_count, still a gauge to preserve the time-series shape.stacking