* updating to the 1.0 src - #2
Closed
sethcall wants to merge 1 commit into
Closed
Conversation
Member
|
I've released v0.0.6. Thank you for notifying me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests pass as long as I removed the \r\n and changed it to \n. I'm not sure if this is because I'm on a mac, or if typescript changed in this way.
Also, I moved the typescript-src dependency to the gemfile because gemspec is limited in what you can specify... for example, path: dependencies which I need to easily turn on while depending on the unpublished typescript-node-src fork of mine.