fix(CMakeLists.txt): Export all symbols by default for MSVC #5191
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scutuatua-crypto
approved these changes
Jan 2, 2026
Author
|
Is there any problem with this PR that's why it hasn't been merged? 🤔 Thanks! |
Member
Anytime there's a problem in Windows-land it's nontrivial to get things working for us to test/debug locally. In addition, the worry is the symbols missing is due to some underlying problem with the library on Windows for any build process (make, CMake, Zig, etc.), meaning that this will patch over the problem for CMake but leave the others broken and out of parity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5190.