This looks OK, thanks, a few comments:

• I think it should check if the state is changed - the is no point in setting the progress bar every time even if it has not changed. You have it in struct client but don't check if it has changed. I'd probably move it to struct tty and do the check in tty_set_progress_bar.

• /* Terminal has sixel capability. */ -> /* Terminal supports the OSC 9;4 progress bar. */

• struct tty* tty -> struct tty *tty (space before *) in the tty_set_progress_bar definition in tty.c.

Thanks for the review! Comments inline.

This looks OK, thanks, a few comments:

I think it should check if the state is changed - the is no point in setting the progress bar every time even if it has not changed. You have it in struct client but don't check if it has changed. I'd probably move it to struct tty and do the check in tty_set_progress_bar.

I now check to make sure it changed but I didn't move it into struct tty since I was following the pattern for title and path, where they're stored in client. Still happy to make that change but it seems like those two at least should change as well?

/* Terminal has sixel capability. / -> / Terminal supports the OSC 9;4 progress bar. */

Done.

struct tty* tty -> struct tty *tty (space before *) in the tty_set_progress_bar definition in tty.c.

Done.

Let me know if you still want me to move this into struct tty. Happy to do it, just wanted to double check it was the right move.

This looks good to me, thanks. The OpenBSD tree is currently locked for release but I'll apply this once it is open again.